http2: multiple cleanups and s/streamClosed/close#17328
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the lib / src 
MemberAuthor
jasnell commented Nov 26, 2017
lib/internal/http2/core.js Outdated
Member
There was a problem hiding this comment.
Is it possible to add a test for this?
MemberAuthor
There was a problem hiding this comment.
There are already tests for it that have been flaky, this should fix those flaky tests. One of the existing ones could be modified to check that a secureConnect handler has been registered.
Member
There was a problem hiding this comment.
@jasnell Can you point me to one? I volunteer to try and make it fail/pass consistently :)
MemberAuthor
There was a problem hiding this comment.
http2-create-client-secure-session is one, which should be fixed by this PR.
I've updated it to include the check for secureConnect
apapirovski approved these changes Nov 26, 2017
lib/internal/http2/compat.js Outdated
Contributor
There was a problem hiding this comment.
Can you remove this and the associated function? They should not be necessary.
lib/internal/http2/compat.js Outdated
Contributor
There was a problem hiding this comment.
Same as above.
Can you remove this and the associated function? They should not be necessary.
lib/internal/http2/core.js Outdated
Contributor
There was a problem hiding this comment.
Could this be a bit more descriptively named? (Similar to setupFn elsewhere in this code.)
MemberAuthor
jasnell commented Nov 27, 2017
sebdeckers approved these changes Nov 27, 2017
Contributor
sebdeckers left a comment
sebdeckers left a comment There was a problem hiding this comment.
LGTM 👍 This event confused me many times. Thanks for clearing it up.
General improvements to test and verify that a secureConnect handler is present
jasnellforce-pushed the http2-refactor4 branch from 2e5bcdb to 4b964e5CompareMemberAuthor
jasnell commented Nov 28, 2017
jasnell added a commit that referenced this pull request Nov 28, 2017
PR-URL: #17328Fixes: #15303 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Sebastiaan Deckers <[email protected]>
jasnell added a commit that referenced this pull request Nov 28, 2017
PR-URL: #17328Fixes: #15303 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Sebastiaan Deckers <[email protected]>
jasnell added a commit that referenced this pull request Nov 28, 2017
PR-URL: #17328Fixes: #15303 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Sebastiaan Deckers <[email protected]>
jasnell added a commit that referenced this pull request Nov 28, 2017
PR-URL: #17328Fixes: #15303 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Sebastiaan Deckers <[email protected]>
jasnell added a commit that referenced this pull request Nov 28, 2017
General improvements to test and verify that a secureConnect handler is present PR-URL: #17328Fixes: #15303 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Sebastiaan Deckers <[email protected]>
jasnell added a commit that referenced this pull request Nov 28, 2017
PR-URL: #17328Fixes: #15303 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Sebastiaan Deckers <[email protected]>
jasnell added a commit that referenced this pull request Nov 28, 2017
PR-URL: #17328Fixes: #15303 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Sebastiaan Deckers <[email protected]>
MemberAuthor
jasnell commented Nov 28, 2017
Landed in 0fb1e07...093a870 |
MylesBorins pushed a commit that referenced this pull request Dec 7, 2017
PR-URL: #17328Fixes: #15303 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Sebastiaan Deckers <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 7, 2017
PR-URL: #17328Fixes: #15303 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Sebastiaan Deckers <[email protected]>
evanlucas pushed a commit that referenced this pull request Dec 7, 2017
PR-URL: #17328Fixes: #15303 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Sebastiaan Deckers <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17328Fixes: #15303 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Sebastiaan Deckers <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17328Fixes: #15303 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Sebastiaan Deckers <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
General improvements to test and verify that a secureConnect handler is present PR-URL: #17328Fixes: #15303 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Sebastiaan Deckers <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17328Fixes: #15303 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Sebastiaan Deckers <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17328Fixes: #15303 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Sebastiaan Deckers <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17328Fixes: #15303 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Sebastiaan Deckers <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17328Fixes: #15303 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Sebastiaan Deckers <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
General improvements to test and verify that a secureConnect handler is present PR-URL: #17328Fixes: #15303 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Sebastiaan Deckers <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17328Fixes: #15303 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Sebastiaan Deckers <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17328Fixes: #15303 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Sebastiaan Deckers <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes multiple cleanups in core.js along with:
streamClosed/cc @nodejs/http2
Fixes: #15303
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2