Skip to content

Commit 145b668

Browse files
zertoshMyles Borins
authored andcommitted
module: move unnecessary work for early return
The exts and trailingSlash variables are only used if the path isn't cached. This commit moves them further down in the code, and changes from var to const. PR-URL: #3579 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
1 parent f28a640 commit 145b668

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

‎lib/module.js‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -126,19 +126,18 @@ function tryExtensions(p, exts){
126126

127127
varwarned=false;
128128
Module._findPath=function(request,paths){
129-
varexts=Object.keys(Module._extensions);
130-
131129
if(path.isAbsolute(request)){
132130
paths=[''];
133131
}
134132

135-
vartrailingSlash=(request.slice(-1)==='/');
136-
137133
varcacheKey=JSON.stringify({request: request,paths: paths});
138134
if(Module._pathCache[cacheKey]){
139135
returnModule._pathCache[cacheKey];
140136
}
141137

138+
constexts=Object.keys(Module._extensions);
139+
consttrailingSlash=request.slice(-1)==='/';
140+
142141
// For each path
143142
for(vari=0,PL=paths.length;i<PL;i++){
144143
// Don't search further if path doesn't exist

0 commit comments

Comments
(0)