module: move unnecessary work for early return#3579
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Trott commented Oct 29, 2015
Trott commented Oct 29, 2015
The first line of the commit message should start with |
zertosh changed the title 
zertosh commented Oct 29, 2015
@Trott done! |
mscdex commented Oct 29, 2015
@Trott Why should it start with |
Trott commented Oct 29, 2015
@mscdex I always thought (wrongly, it seems!) that we standardize on the nice short directory names in the top-level directory as much as possible. So @zertosh Sorry for the bad suggestion. |
zertosh changed the title zertosh commented Oct 29, 2015
no worries @Trott |
jbergstroem commented Oct 29, 2015
Afaik -- prefixes usually stick to the filenames in |
jasnell commented Oct 29, 2015
@nodejs/ctc |
trevnorris commented Oct 29, 2015
Mostly what @jbergstroem. The name should be the most closely related subsystem you pass to either |
rvagg commented Oct 30, 2015
If it's not obvious, just pick one, |
zertosh commented Oct 31, 2015
Seems like everyone is Ok on this- even the commit prefix. Merge? EDIT: Meant this for #3578 |
trevnorris commented Nov 1, 2015
LGTM. |
jasnell commented Nov 5, 2015
LGTM |
MylesBorins commented Jan 7, 2016
@jasnell@trevnorris should this be merged? |
cjihrig commented Jan 7, 2016
LGTM. We could probably change the |
lib/module.js Outdated
There was a problem hiding this comment.
While you're at it, the parenthesis on this line are unnecessary.
jasnell commented Jan 7, 2016
`exts` and `trailingSlash` are only used if the path isn't cached.
zertosh commented Jan 8, 2016
@cjihrig: I've rebased on top of master and switched the |
cjihrig commented Jan 8, 2016
Thanks. Last CI was all green, but running one more time just to make sure switching to |
Trott commented Jan 8, 2016
Ci is green green green. |
targos commented Jan 8, 2016
LGTM |
The exts and trailingSlash variables are only used if the path isn't cached. This commit moves them further down in the code, and changes from var to const. PR-URL: #3579 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
cjihrig commented Jan 11, 2016
Landed in 1285671. Thanks! |
The exts and trailingSlash variables are only used if the path isn't cached. This commit moves them further down in the code, and changes from var to const. PR-URL: #3579 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
The exts and trailingSlash variables are only used if the path isn't cached. This commit moves them further down in the code, and changes from var to const. PR-URL: #3579 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Notable Changes: * Minor performance improvements: - module: move unnecessary work for early return (Andres Suarez) #3579 * Various bug fixes * Various doc fixes * Various test improvements PR-URL: #4626 Reviewed-By: Jeremiah Senkpiel <[email protected]>
The exts and trailingSlash variables are only used if the path isn't cached. This commit moves them further down in the code, and changes from var to const. PR-URL: #3579 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
The exts and trailingSlash variables are only used if the path isn't cached. This commit moves them further down in the code, and changes from var to const. PR-URL: #3579 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
The exts and trailingSlash variables are only used if the path isn't cached. This commit moves them further down in the code, and changes from var to const. PR-URL: nodejs#3579 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
The exts and trailingSlash variables are only used if the path isn't cached. This commit moves them further down in the code, and changes from var to const. PR-URL: nodejs#3579 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
The exts and trailingSlash variables are only used if the path isn't cached. This commit moves them further down in the code, and changes from var to const. PR-URL: nodejs#3579 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Notable Changes: * Minor performance improvements: - module: move unnecessary work for early return (Andres Suarez) nodejs#3579 * Various bug fixes * Various doc fixes * Various test improvements PR-URL: nodejs#4626 Reviewed-By: Jeremiah Senkpiel <[email protected]>
11 participants
extsandtrailingSlashare only used if the path isn't cached.