stream: don't emit prefinish after error or close

PR-URL: #39332 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: ronag

lib/internal/streams/writable.js

@@ -654,7 +654,9 @@ function needFinish(state){
 !state.errored&&
 state.buffered.length===0&&
 !state.finished&&
-!state.writing);
+!state.writing&&
+!state.errorEmitted&&
+!state.closeEmitted);
 }
 
 functioncallFinal(stream,state){
@@ -685,7 +687,7 @@ function callFinal(stream, state){
 then.call(
 result,
 function(){
-if(state.prefinished)
+if(state.prefinished||!needFinish(state))
 return;
 state.prefinish=true;
 process.nextTick(()=>stream.emit('prefinish'));
@@ -735,10 +737,6 @@ function finishMaybe(stream, state, sync){
 
 functionfinish(stream,state){
 state.pendingcb--;
-// TODO (ronag): Unify with needFinish.
-if(state.errorEmitted||state.closeEmitted)
-return;
-
 state.finished=true;
 
 constonfinishCallbacks=state[kOnFinished].splice(0);

test/parallel/test-stream-writable-final-destroy.js

@@ -0,0 +1,21 @@
+'use strict';
+constcommon=require('../common');
+
+const{ Writable }=require('stream');
+
+{
+constw=newWritable({
+write(chunk,encoding,callback){
+callback(null);
+},
+final(callback){
+queueMicrotask(callback);
+}
+});
+w.end();
+w.destroy();
+
+w.on('prefinish',common.mustNotCall());
+w.on('finish',common.mustNotCall());
+w.on('close',common.mustCall());
+}