Skip to content

stream: don't emit prefinish after error or close#39332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ronag wants to merge 1 commit into from
Closed

stream: don't emit prefinish after error or close #39332

ronag wants to merge 1 commit into from

Conversation

@ronag
Copy link
Member

@ronagronag commented Jul 9, 2021

No description provided.

@ronagronag added stream Issues and PRs related to the stream subsystem. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 9, 2021
@ronagronag requested a review from mcollinaJuly 9, 2021 22:37
@ronag
Copy link
MemberAuthor

ronag commented Jul 9, 2021

@nodejs/streams

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 9, 2021
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 9, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/38927/

mcollina
mcollina approved these changes Jul 10, 2021
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

mcollina commented Jul 10, 2021

This looks like a patch, but it could be breaking. I've added a labels so that it is not backported to v14 straight away.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 10, 2021•
edited by ronag
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/38935/ ✅

@ronagronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. and removed needs-ci PRs that need a full CI run. labels Jul 10, 2021
ronag added a commit that referenced this pull request Jul 11, 2021
@ronag
stream: don't emit prefinish after error or close
7a7ba82
PR-URL: #39332 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
@ronag
Copy link
MemberAuthor

ronag commented Jul 11, 2021

Landed in 7a7ba82

@ronagronag closed this Jul 11, 2021
targos pushed a commit that referenced this pull request Jul 13, 2021
@ronag@targos
stream: don't emit prefinish after error or close
1fc6382
PR-URL: #39332 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
@targostargos mentioned this pull request Jul 13, 2021
Merged
@targos
Copy link
Member

targos commented Sep 4, 2021•
edited
Loading

It doesn't land cleanly on v14.x-staging.

I've added a labels so that it is not backported to v14 straight away.

baking-for-lts is needed for this. We use lts-watch labels to find PRs that people actually want to be backported.

@targostargos added the baking-for-lts PRs that need to wait before landing in a LTS release. label Sep 4, 2021
@martin-g
Copy link

martin-g commented Oct 6, 2021

This change somehow breaks Apache Avro JS module [1] [2]. With Node.js 16 the finish event is not emitted for a Transform anymore. I've added:

.on('prefinish', function (){console.log('--- prefinish')}) .on('error', function (){console.log('--- error')}) .on('close', function (){console.log('--- close')}) .on('finish', function (){...

to the MessageDecoder (a Transformer) but none of them is triggered.

The only way to "fix" the tests is to emit finish manually: apache/avro#1354

Do you have an idea what is going wrong ?

  1. https://github.com/apache/avro/blob/8f0b8d68c3fc10b6a5fc09bae4a5c30defe53897/lang/js/lib/protocols.js#L1050-L1103
  2. https://github.com/apache/avro/blob/8f0b8d68c3fc10b6a5fc09bae4a5c30defe53897/lang/js/test/test_protocols.js#L200-L219

@martin-gmartin-g mentioned this pull request Oct 6, 2021
Merged
1 task
@targostargos removed baking-for-lts PRs that need to wait before landing in a LTS release. backport-requested-v14.x labels Sep 16, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@jasnelljasnelljasnell approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.review wantedPRs that need reviews.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ronag@nodejs-github-bot@mcollina@targos@martin-g@jasnell