Skip to content

Commit 2149acd

Browse files
F3n67utargos
authored andcommitted
dns: make promise API fully constructed from lib/internal/dns/promises
PR-URL: #43227 Refs: https://github.com/nodejs/node/discussions/43198 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
1 parent 9bd13bb commit 2149acd

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

‎lib/dns.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -439,8 +439,6 @@ ObjectDefineProperties(module.exports,{
439439
get(){
440440
if(promises===null){
441441
promises=require('internal/dns/promises');
442-
promises.setServers=defaultResolverSetServers;
443-
promises.setDefaultResultOrder=setDefaultResultOrder;
444442
}
445443
returnpromises;
446444
}

‎lib/dns/promises.js‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
'use strict';
22

3-
constdnsPromises=require('internal/dns/promises');
4-
dnsPromises.setServers=require('dns').setServers;
5-
module.exports=dnsPromises;
3+
module.exports=require('internal/dns/promises');

‎lib/internal/dns/promises.js‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ const{
1717
emitInvalidHostnameWarning,
1818
getDefaultVerbatim,
1919
errorCodes: dnsErrorCodes,
20+
setDefaultResultOrder,
21+
setDefaultResolver,
2022
}=require('internal/dns/utils');
2123
const{
2224
NODATA,
@@ -349,11 +351,20 @@ Resolver.prototype.resolve = function resolve(hostname, rrtype){
349351
returnReflectApply(resolver,this,[hostname]);
350352
};
351353

354+
functiondefaultResolverSetServers(servers){
355+
constresolver=newResolver();
356+
357+
resolver.setServers(servers);
358+
setDefaultResolver(resolver);
359+
bindDefaultResolver(module.exports,Resolver.prototype);
360+
}
352361

353362
module.exports={
354363
lookup,
355364
lookupService,
356365
Resolver,
366+
setDefaultResultOrder,
367+
setServers: defaultResolverSetServers,
357368

358369
// ERROR CODES
359370
NODATA,

0 commit comments

Comments
(0)