Skip to content

dns: make promise API fully constructed from lib/internal/dns/promises#43227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jun 20, 2022
Merged

dns: make promise API fully constructed from lib/internal/dns/promises#43227

nodejs-github-bot merged 1 commit into from
Jun 20, 2022

Conversation

@F3n67u
Copy link
Contributor

@F3n67uF3n67u commented May 28, 2022

This pr makes the whole promise API be fully constructed from lib/internal/dns/promises.js, it should not be split between lib/dns.js and lib/internal/dns/promises.js.

Refs: https://github.com/nodejs/node/discussions/43198

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 28, 2022

Review requested:

  • @nodejs/net

@nodejs-github-botnodejs-github-bot added dns Issues and PRs related to the dns subsystem. needs-ci PRs that need a full CI run. labels May 28, 2022
@F3n67uF3n67u marked this pull request as ready for review May 28, 2022 06:07
@F3n67uF3n67u changed the title dns: make the whole promise API be fully constructed from lib/internal/dns/promises.jsdns: make promise API be fully constructed from lib/internal/dns/promises.jsMay 28, 2022
@F3n67uF3n67u changed the title dns: make promise API be fully constructed from lib/internal/dns/promises.jsdns: make promise API fully constructed from lib/internal/dns/promises.jsMay 28, 2022
@F3n67uF3n67uforce-pushed the fix/dns branch 2 times, most recently from bbb4612 to eea50faCompareMay 28, 2022 06:11
@F3n67uF3n67u changed the title dns: make promise API fully constructed from lib/internal/dns/promises.jsdns: make promise API fully constructed from lib/internal/dns/promisesMay 28, 2022
mcollina
mcollina approved these changes May 28, 2022
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label May 28, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 28, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actionsgithub-actionsbot mentioned this pull request May 29, 2022
Open
18 tasks
@F3n67u
Copy link
ContributorAuthor

F3n67u commented May 29, 2022•
edited
Loading

Jenkins test is failed, please help to fire another Jenkins try.

There is two js test fail: parallel/test-worker-http2-stream-terminate and node-api/test_buffer/test_finalizer.

parallel/test-worker-http2-stream-terminate is a known flaky test, see #43084.

node-api/test_buffer/test_finalizer is failed 6 times today, perhaps not caused by this pr.

@github-actionsgithub-actionsbot mentioned this pull request May 30, 2022
Open
18 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 30, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44233/

This was referenced May 31, 2022
Open
Open
Open
Open
@github-actionsgithub-actionsbot mentioned this pull request Jun 4, 2022
Open
21 tasks
@F3n67uF3n67uforce-pushed the fix/dns branch 2 times, most recently from 280b9d5 to afa6194CompareJune 18, 2022 13:16
@F3n67u
Copy link
ContributorAuthor

F3n67u commented Jun 18, 2022

I rebased main branch to resolve a conflict.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 19, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44719/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 19, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44720/

@github-actionsgithub-actionsbot mentioned this pull request Jun 20, 2022
Open
36 tasks
@F3n67uF3n67u added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 20, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44740/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 20, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44761/

mcollina
mcollina approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jun 20, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2022
@nodejs-github-botnodejs-github-bot merged commit 3847617 into nodejs:mainJun 20, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 20, 2022

Landed in 3847617

@F3n67uF3n67u deleted the fix/dns branch June 21, 2022 00:09
@F3n67u
Copy link
ContributorAuthor

F3n67u commented Jun 21, 2022

lgtm

@mcollina thanks for landing this pr.

This was referenced Jun 21, 2022
Open
Open
Open
Open
F3n67u added a commit to F3n67u/node that referenced this pull request Jun 24, 2022
@F3n67u
dns: make promise API fully constructed from lib/internal/dns/promises
2dae13f
PR-URL: nodejs#43227 Refs: https://github.com/nodejs/node/discussions/43198 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
@F3n67u@targos
dns: make promise API fully constructed from lib/internal/dns/promises
2149acd
PR-URL: #43227 Refs: https://github.com/nodejs/node/discussions/43198 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
@targostargos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
@F3n67u@targos
dns: make promise API fully constructed from lib/internal/dns/promises
a8f7d0d
PR-URL: #43227 Refs: https://github.com/nodejs/node/discussions/43198 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@F3n67u@targos
dns: make promise API fully constructed from lib/internal/dns/promises
8d2a256
PR-URL: #43227 Refs: https://github.com/nodejs/node/discussions/43198 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
@targostargos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@F3n67u@guangwong
dns: make promise API fully constructed from lib/internal/dns/promises
22f4881
PR-URL: nodejs/node#43227 Refs: https://github.com/nodejs/node/discussions/43198 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@lpincalpincalpinca approved these changes

@targostargostargos approved these changes

@JungMinuJungMinuJungMinu approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.dnsIssues and PRs related to the dns subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@F3n67u@nodejs-github-bot@mcollina@lpinca@targos@JungMinu