Skip to content

Conversation

@targos
Copy link
Member

@targostargos commented Jul 12, 2022

2022-07-13, Version 18.6.0 (Current), @targos

Notable Changes

Experimental ESM Loader Hooks API

Node.js ESM Loader hooks now support multiple custom loaders, and composition is
achieved via "chaining": foo-loader calls bar-loader calls qux-loader
(a custom loader must now signal a short circuit when intentionally not
calling the next). See the ESM docs for details.

Real-world use-cases are laid out for end-users with working examples in the
article Custom ESM loaders: Who, what, when, where, why, how.

Contributed by Jacob Smith, Geoffrey Booth, and Bradley Farias - #42623

Commits

Semver-minor commits

  • [0bca7b722e] - (SEMVER-MINOR)dns: export error code constants from dns/promises (Feng Yu) #43176
  • [da61e2330f] - (SEMVER-MINOR)esm: add chaining to loaders (Jacob Smith) #42623
  • [8c97f63401] - (SEMVER-MINOR)http: add diagnostics channel for http client (theanarkh) #43580
  • [b27856d3d4] - (SEMVER-MINOR)http: add perf_hooks detail for http request and client (theanarkh) #43361
  • [9d918d9923] - (SEMVER-MINOR)module: add isBuiltIn method (hemanth.hm) #43396
  • [a0e7b9983c] - (SEMVER-MINOR)net: add drop event for net server (theanarkh) #43582
  • [4bda6e02a3] - (SEMVER-MINOR)test_runner: expose describe and it (Moshe Atlow) #43420
  • [34e83312a4] - (SEMVER-MINOR)v8: add v8.startupSnapshot utils (Joyee Cheung) #43329

Semver-patch commits

Documentation commits

Other commits

JakobJingleheimerand others added 30 commits July 12, 2022 07:40
PR-URL: #42623 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #43130 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #43164 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
PR-URL: #43386 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #43359 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Rich Trott <[email protected]> Co-authored-by: Antoine du Hamel <[email protected]>
Refs: #33864 PR-URL: #43438 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Signed-off-by: Michael Dawson <[email protected]> PR-URL: #43453 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #43431 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #43431 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #43431 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #43431 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #43431 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #43443 Refs: #33864 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #43437 Refs: #33864 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #43441 Refs: #33864 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #43442 Refs: #33864 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #43440 Refs: #33864 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Fixes: #43274 PR-URL: #43336 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #43418 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This reverts commit 73d8db8. PR-URL: #43418 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This resolves this TODO - https://github.com/nodejs/node/blob/71071f896aa9696b5d36bb3bec1c7217e7420509/src/stream_wrap.cc#L111-L112. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #43321 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]>
Add the `--max_semi_space_size` flag into useful V8 option. Fixes: #42511 PR-URL: #42575 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Refs: #33864 PR-URL: #43445 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #42790 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This adds several APIs under the `v8.startupSnapshot` namespace for specifying hooks into the startup snapshot serialization and deserialization. - isBuildingSnapshot() - addSerializeCallback() - addDeserializeCallback() - setDeserializeMainFunction() PR-URL: #43329Fixes: #42617 Refs: #35711 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]>
Refs: #43363 (comment) PR-URL: #43374 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
The test is causing a lot of CI failures, so I'd say that we should mark this test flaky until someone comes up with a proper fix. Refs: #43084 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #43425 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
This is specially prevalent in the case of having in-progress FileHandle operations in a worker thread while the Worker is exiting. Fixes: #42829 PR-URL: #42910 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Notable changes: - esm: add chaining to loaders PR-URL: #43789
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 13, 2022

@targos
Copy link
MemberAuthor

@nodejs/build I just tried to execute the binary downloaded from https://ci-release.nodejs.org/job/iojs+release/8603/nodes=osx11-release-tar/ and macOS doesn't let me:
image

Is this expected?
image

@richardlau

This comment was marked as outdated.

@Trott
Copy link
Member

@Trott it seems that Gitpod is doing unnecessary stuff?

@targos You mean the widget status about prebuilt workspaces? I thought I configured it to only do that on the main branch and to not post a notification about it. Clearly, that's not the case. I'll look into it. If there's something else it's doing that I need to track down, let me know! Thanks!

@Trott
Copy link
Member

I thought I configured it to only do that on the main branch

I see what I messed up there. I'll open a PR to fix. I assume it's not blocking the release, though. Let me know if it is, of course.

@BethGriggs
Copy link
Member

BethGriggs commented Jul 13, 2022

@targos, I am sure I vaguely recall this problem before. It was to do with opening it from a browser download. I'll try and find the historic comments.

(I am sure that is the same problem I hit before, because I can reproduce your error when downloading from https://nodejs.org/download/nightly/v19.0.0-nightly2022071390bc773fb8/node-v19.0.0-nightly2022071390bc773fb8-darwin-x64.tar.gz in the browser, but not when downloading using wget.)

(Edit: I do not see this when testing the binaries on my laptop because I always use the installer - and I think the reason I started to always use the installer for testing is because of this issue 😅)

Trott added a commit to Trott/io.js that referenced this pull request Jul 13, 2022
Disable prebuilds for pull requests. addCOmment now defaults to false so we don't need to set it anymore. Refs: nodejs#43789 (comment) Refs: https://www.gitpod.io/docs/prebuilds#github-specific-configuration
Trott added a commit to Trott/io.js that referenced this pull request Jul 13, 2022
Disable prebuilds for pull requests. addCOmment now defaults to false so we don't need to set it anymore. Refs: nodejs#43789 (comment) Refs: https://www.gitpod.io/docs/prebuilds#github-specific-configuration
@TrottTrott mentioned this pull request Jul 13, 2022
@richardlau
Copy link
Member

@targos, I am sure I vaguely recall this problem before. It was to do with opening it from a browser download. I'll try and find the historic comments.

Found nodejs/build#2188 (comment) 👀

@targos
Copy link
MemberAuthor

OK thanks, I don't know how to download it from Jenkins with Curl so I'll proceed assuming it's the same problem.

Trott added a commit to Trott/io.js that referenced this pull request Jul 13, 2022
Disable prebuilds for pull requests. addComment now defaults to false so we don't need to set it anymore. Refs: nodejs#43789 (comment) Refs: https://www.gitpod.io/docs/prebuilds#github-specific-configuration
@targostargos merged commit cd17157 into v18.xJul 13, 2022
targos added a commit that referenced this pull request Jul 13, 2022
@targostargos deleted the v18.6.0-proposal branch July 13, 2022 20:51
targos added a commit that referenced this pull request Jul 13, 2022
Notable changes: - esm: add chaining to loaders PR-URL: #43789
targos added a commit to targos/nodejs.org that referenced this pull request Jul 13, 2022
Trott added a commit to Trott/io.js that referenced this pull request Jul 13, 2022
Disable prebuilds for pull requests. addComment now defaults to false so we don't need to set it anymore. Refs: nodejs#43789 (comment) Refs: https://www.gitpod.io/docs/prebuilds#github-specific-configuration
@TrottTrott mentioned this pull request Jul 13, 2022
targos added a commit to nodejs/nodejs.org that referenced this pull request Jul 13, 2022
nodejs-github-bot pushed a commit that referenced this pull request Jul 14, 2022
Disable prebuilds for pull requests. addComment now defaults to false so we don't need to set it anymore. Refs: #43789 (comment) Refs: https://www.gitpod.io/docs/prebuilds#github-specific-configuration PR-URL: #43829 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 26, 2022
Disable prebuilds for pull requests. addComment now defaults to false so we don't need to set it anymore. Refs: #43789 (comment) Refs: https://www.gitpod.io/docs/prebuilds#github-specific-configuration PR-URL: #43829 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
Disable prebuilds for pull requests. addComment now defaults to false so we don't need to set it anymore. Refs: #43789 (comment) Refs: https://www.gitpod.io/docs/prebuilds#github-specific-configuration PR-URL: #43829 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Disable prebuilds for pull requests. addComment now defaults to false so we don't need to set it anymore. Refs: nodejs/node#43789 (comment) Refs: https://www.gitpod.io/docs/prebuilds#github-specific-configuration PR-URL: nodejs/node#43829 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metaIssues and PRs related to the general management of the project.needs-ciPRs that need a full CI run.releaseIssues and PRs related to Node.js releases.v18.xIssues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

20 participants

@targos@nodejs-github-bot@JakobJingleheimer@mcollina@panva@richardlau@Trott@BethGriggs@tniessen@RafaelGSS@RaisinTen@aduh95@guybedford@manekinekko@lpinca@mhdawson@F3n67u@meixg@zhmushan@JialuZhang-intel