Skip to content

esm: restore next<HookName>'s context as optional arg#43553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 3 commits into from
Jul 2, 2022
Merged

esm: restore next<HookName>'s context as optional arg #43553

nodejs-github-bot merged 3 commits into from
Jul 2, 2022

Conversation

@JakobJingleheimer
Copy link
Member

@JakobJingleheimerJakobJingleheimer commented Jun 23, 2022

This PR ports some internal code improvements otherwise lost when #43363 was reverted. It also contains a small bugfix wherein the context argument of next<HookName>() (or default<HookName>() prior to chaining) was actually optional.

@JakobJingleheimerJakobJingleheimer added esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders labels Jun 23, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 23, 2022

Review requested:

  • @nodejs/modules

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 23, 2022
aduh95
aduh95 reviewed Jun 23, 2022
View reviewed changes
aduh95
aduh95 reviewed Jun 24, 2022
View reviewed changes
aduh95
aduh95 reviewed Jun 24, 2022
View reviewed changes
test/fixtures/es-module-loaders/loader-load-null-return.mjs
@@ -0,0 +1,3 @@
exportasyncfunctionload(specifier,context,next){
Copy link
Contributor

@aduh95aduh95Jun 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also have a test for when the return value is null instead of Promise<null>?

Suggested change
exportasyncfunctionload(specifier,context,next){
exportfunctionload(specifier,context,next){

Copy link
MemberAuthor

@JakobJingleheimerJakobJingleheimerJun 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Will do tomorrow (alternatively in the tidy follow-up I'm about to do)

PS gaah, yah killin me with the drip-feeding 😜

aduh95
aduh95 approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@aduh95aduh95 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming #43558 fixes the failing test

@JakobJingleheimerJakobJingleheimerforce-pushed the esm/fix-optional-context-arg branch from 4227327 to 1f380d1CompareJune 25, 2022 11:22
@JakobJingleheimerJakobJingleheimerforce-pushed the esm/fix-optional-context-arg branch from 1f380d1 to cb738d6CompareJuly 1, 2022 18:35
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 1, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/45037/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 1, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/45042/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 2, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/45043/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 2, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/45044/

@GeoffreyBoothGeoffreyBooth added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jul 2, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 2, 2022
@nodejs-github-botnodejs-github-bot merged commit 1f6d005 into nodejs:mainJul 2, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 2, 2022

Landed in 1f6d005

@GeoffreyBoothGeoffreyBooth deleted the esm/fix-optional-context-arg branch July 2, 2022 04:53
@github-actionsgithub-actionsbot mentioned this pull request Jul 4, 2022
Open
23 tasks
@github-actionsgithub-actionsbot mentioned this pull request Jul 8, 2022
Open
16 tasks
targos pushed a commit that referenced this pull request Jul 12, 2022
@JakobJingleheimer@targos
esm: restore next<HookName>'s context as optional arg
953fefe
PR-URL: #43553 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
@targostargos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
@JakobJingleheimer@targos
esm: restore next<HookName>'s context as optional arg
1cda175
PR-URL: #43553 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@JakobJingleheimer@targos
esm: restore next<HookName>'s context as optional arg
33a2902
PR-URL: #43553 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
@targostargos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@JakobJingleheimer@guangwong
esm: restore next<HookName>'s context as optional arg
8430cf9
PR-URL: nodejs/node#43553 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes

@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.esmIssues and PRs related to the ECMAScript Modules implementation.loadersIssues and PRs related to ES module loaders

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JakobJingleheimer@nodejs-github-bot@jasnell@GeoffreyBooth@aduh95