test: mark test-worker-http2-stream-terminate flaky on all platforms#43620
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actionsbot removed the request-ci 
This comment was marked as outdated.
This comment was marked as outdated.
F3n67u added fast-track 
Contributor
Fast-track has been requested by @F3n67u. Please 👍 to approve. |
LiviaMedeiros approved these changes Jun 29, 2022
Member
LiviaMedeiros left a comment
LiviaMedeiros left a comment There was a problem hiding this comment.
Would "test: mark test-worker-http2-stream-terminate flaky on all platforms" be a more accurate commit message?
F3n67u changed the title 
F3n67uforce-pushed the flaky-test-worker-http2-stream-terminate branch from 91ca85d to 9a21438Compare
ContributorAuthor
F3n67u commented Jun 30, 2022
good catch. fixed. |
RaisinTen added the author ready This comment was marked as outdated.
This comment was marked as outdated.
targos approved these changes Jun 30, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
tniessen approved these changes Jul 1, 2022
ContributorAuthor
F3n67u commented Jul 1, 2022
Hi. collaborators! could you help to resume ci? |
This comment was marked as outdated.
This comment was marked as outdated.
ContributorAuthor
F3n67u commented Jul 1, 2022
Please help to resume ci again. our old flaky friend |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
nodejs-github-bot commented Jul 1, 2022
LiviaMedeiros added the commit-queue 
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jul 1, 2022
Landed in 2bd940c |
23 tasks
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43620 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Jul 20, 2022
PR-URL: #43620 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43620 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43620 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #43084 (comment)