doc: fix icu-small example#43591
Closed
doc: fix icu-small example #43591
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Running the same in the icu doc shows that for icu-small the output is January instead of M01. Update the example in the doc to match. Signed-off-by: Michael Dawson <[email protected]>
MemberAuthor
mhdawson commented Jun 27, 2022
@srl295 does this make sense to you? I suspect at one point it printed M01 but currently it seems to default to using the english value instead of the code when the data is not available. |
jasnell approved these changes Jun 27, 2022
srl295 approved these changes Jun 27, 2022
Member
srl295 left a comment
srl295 left a comment There was a problem hiding this comment.
This has been true all the way back to v0.12.18!
Member
srl295 commented Jun 27, 2022
I think this was probably true for an interim version where the manifest (list of installed locales) wasn't updated properly. But yes , it should resolve to your user's default (such as >spanish.resolvedOptions();{locale: 'en-US', numberingSystem: 'latn', calendar: 'gregory', timeZone: 'America/Chicago', month: 'long' } |
Member
srl295 commented Jun 27, 2022
OK stop press. issue… |
Member
srl295 commented Jun 27, 2022
$ env LANG=es_US node -p 'new Intl.DateTimeFormat("es",{month: "long" }).format(new Date(9e8));' M01 $ env LANG=en_US node -p 'new Intl.DateTimeFormat("es",{month: "long" }).format(new Date(9e8));' January🤦 user environment sensitive tests… |
srl295 reviewed Jun 27, 2022
Uh oh!
There was an error while loading. Please reload this page.
Member
srl295 commented Jun 27, 2022
fyi @nodejs/i18n-api |
Co-authored-by: Steven R. Loomis <[email protected]>
MemberAuthor
mhdawson commented Jun 27, 2022
@srl295 thanks for catching that its dependent on the default locale. That may help resolve the original question I had which led me to look at this doc/find the difference. |
tniessen approved these changes Jun 28, 2022
MemberAuthor
mhdawson commented Jun 30, 2022
Landed in bbab209 |
mhdawson added a commit that referenced this pull request Jun 30, 2022
Running the same in the icu doc shows that for icu-small the output is January instead of M01. Update the example in the doc to match. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #43591 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
Running the same in the icu doc shows that for icu-small the output is January instead of M01. Update the example in the doc to match. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #43591 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Jul 20, 2022
Running the same in the icu doc shows that for icu-small the output is January instead of M01. Update the example in the doc to match. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #43591 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
Running the same in the icu doc shows that for icu-small the output is January instead of M01. Update the example in the doc to match. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #43591 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Running the same in the icu doc shows that for icu-small the output is January instead of M01. Update the example in the doc to match. Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs/node#43591 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the same in the icu doc shows that for
icu-small the output is January instead of M01. Update
the example in the doc to match.
Signed-off-by: Michael Dawson [email protected]