wasi: use WasmMemoryObject handle for perf#43544
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Jun 23, 2022
Review requested:
|
nodejs-github-bot added c++ 
devsnekforce-pushed the use-wasm-memory-object-type branch 3 times, most recently from 0424be9 to 49c3b76Compare
tniessen approved these changes Jun 23, 2022
cjihrig approved these changes Jun 23, 2022
devsnekforce-pushed the use-wasm-memory-object-type branch 2 times, most recently from d7ead7a to 5a05d10Compare
addaleax approved these changes Jun 23, 2022
| Local<ArrayBuffer> ab = prop.As<ArrayBuffer>(); | ||
| std::shared_ptr<BackingStore> backing_store = ab->GetBackingStore(); | ||
| Local<WasmMemoryObject> memory = PersistentToLocal::Strong(this->memory_); |
Member
There was a problem hiding this comment.
tiny and very ignorable style nit:
Suggested change
| Local<WasmMemoryObject> memory = PersistentToLocal::Strong(this->memory_); | |
| Local<WasmMemoryObject> memory = PersistentToLocal::Strong(memory_); |
More directly, why are we not going on step further and storing the std::shared_ptr<BackingStore> here? That should be even faster.
MemberAuthor
There was a problem hiding this comment.
the arraybuffer gets detached every time the wasm grows its memory. very annoying problem, maybe it will be fixed one day: https://github.com/tc39/proposal-resizablearraybuffer#sync-up-capability-with-webassembly-memorygrow
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Jun 24, 2022
This comment was marked as outdated.
This comment was marked as outdated.
devsnekforce-pushed the use-wasm-memory-object-type branch from c440735 to 98a1262CompareCollaborator
nodejs-github-bot commented Jun 25, 2022
PR-URL: #43544 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
devsnekforce-pushed the use-wasm-memory-object-type branch from 98a1262 to 4778831Comparedevsnek added a commit that referenced this pull request Jun 25, 2022
PR-URL: #43544 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
This was referenced Jun 26, 2022
23 tasks
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43544 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Jul 20, 2022
PR-URL: #43544 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43544 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store
WebAssembly.Memoryhandle as aWasmMemoryObject, which lets us directly grab theArrayBufferinstead of doing a property lookup in this hot path.