doc: remove appmetrics from tierlist#43608
Closed
+0 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Jun 28, 2022
Review requested:
|
BethGriggs approved these changes Jun 28, 2022
Member
BethGriggs left a comment
BethGriggs left a comment There was a problem hiding this comment.
Was this referring to https://github.com/RuntimeTools/appmetrics? If so, to my knowledge that tool is not really maintained any more - so, it does make sense to be dropped.
(I used to share an office with the team who used to maintain it.)
richardlau approved these changes Jun 29, 2022
gireeshpunathil approved these changes Jun 29, 2022
RaisinTen approved these changes Jun 29, 2022
RafaelGSS approved these changes Jun 29, 2022
Flarna approved these changes Jun 29, 2022
MemberAuthor
tony-go commented Jun 30, 2022
Yeah, that's the one ^^ Sorry I forgot to put a link in these PRs. |
RafaelGSS added the author ready MemberAuthor
tony-go commented Jul 1, 2022
Sorry I'll rebase :/ |
tony-goforce-pushed the remove-appmetrics-tierlist branch from 8bd22ac to c14b758CompareMemberAuthor
tony-go commented Jul 2, 2022
Rebased ↪️ |
tony-goforce-pushed the remove-appmetrics-tierlist branch from c14b758 to 1f110c1Compare
tony-goforce-pushed the remove-appmetrics-tierlist branch from 1f110c1 to e86f749Compare
Member
lpinca commented Jul 3, 2022
Landed in 92cd726. |
lpinca pushed a commit that referenced this pull request Jul 3, 2022
PR-URL: #43608 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Gerhard St<C3><B6>bich <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43608 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Gerhard St<C3><B6>bich <[email protected]>
targos pushed a commit that referenced this pull request Jul 20, 2022
PR-URL: #43608 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Gerhard St<C3><B6>bich <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43608 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Gerhard St<C3><B6>bich <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43608 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Gerhard St<C3><B6>bich <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey 👋
Context
The diagnostic working group currently works on an initiative to re-evaluate the diagnostic tooling list and its maturity.
Updated
In the previous instance, we examined the case of the
appmetricsmodule: issue link.As anyone in the instance has an idea about a potential usage in the field, we decided to remove it. As said in the previous PRs, we prefer to have a list that contains fewer items but is trustable.
But in case you have a different opinion, please share your thoughts in this PR 🙏.
Discuss
As usual, feel free to share your thoughts on that and your experience with this tool.
With love ❤️
cc @nodejs/diagnostics