test: rename test-eventtarget-whatwg-*.js#43467
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
lpinca approved these changes Jun 18, 2022
aduh95 approved these changes Jun 18, 2022
aduh95 added fast-track 
Contributor
Fast-track has been requested by @aduh95. Please 👍 to approve. |
Contributor
mscdex commented Jun 18, 2022
For commits/PRs that only touch tests, it's better to use the |
This renames some test filenames to align with the existing `parallel/test-whatwg-*.js` for consistency. According to the comment in each file, they are seemingly manually ported from the `wpt@dom/events` tests. Signed-off-by: Daeyeon Jeong [email protected]
daeyeonforce-pushed the main.renaming-220618.Sat.33ec branch from 1e03c41 to 3ca9e2eComparedaeyeon changed the title test-eventtarget-whatwg-*.jstest-eventtarget-whatwg-*.js
Contributor
aduh95 commented Jun 18, 2022
Landed in f209aee |
targos pushed a commit that referenced this pull request Jul 12, 2022
This renames some test filenames to align with the existing `parallel/test-whatwg-*.js` for consistency. According to the comment in each file, they are seemingly manually ported from the `wpt@dom/events` tests. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: #43467 Refs: #43461 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 18, 2022
This renames some test filenames to align with the existing `parallel/test-whatwg-*.js` for consistency. According to the comment in each file, they are seemingly manually ported from the `wpt@dom/events` tests. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: #43467 Refs: #43461 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
This renames some test filenames to align with the existing `parallel/test-whatwg-*.js` for consistency. According to the comment in each file, they are seemingly manually ported from the `wpt@dom/events` tests. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: #43467 Refs: #43461 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
This renames some test filenames to align with the existing `parallel/test-whatwg-*.js` for consistency. According to the comment in each file, they are seemingly manually ported from the `wpt@dom/events` tests. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: nodejs/node#43467 Refs: nodejs/node#43461 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames some test filenames to align with the existing
parallel/test-whatwg-*.jsfor consistency.According to the comment in each file, they are seemingly manually
ported from the wpt
dom/eventstests.node/test/parallel/test-eventtarget-whatwg-once.js
Line 9 in 61c7103
node/test/parallel/test-eventtarget-whatwg-passive.js
Line 5 in 61c7103
node/test/parallel/test-eventtarget-whatwg-signal.js
Line 9 in 61c7103
node/test/parallel/test-eventtarget-whatwg-customevent.js
Line 7 in 61c7103
Refs: #43461
Signed-off-by: Daeyeon Jeong [email protected]