Skip to content

Conversation

@vweevers
Copy link
Contributor

To match the default value of allowHalfOpen in new stream.Duplex(options).

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Jul 3, 2022
@lpincalpinca added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 4, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.

@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 5, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 5, 2022
@nodejs-github-botnodejs-github-bot merged commit 029215d into nodejs:mainJul 5, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 029215d

@vweeversvweevers deleted the doc-allowhalfopen branch July 5, 2022 18:50
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43665 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
@targostargos mentioned this pull request Jul 12, 2022
targos pushed a commit that referenced this pull request Jul 20, 2022
PR-URL: #43665 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43665 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
@targostargos mentioned this pull request Aug 3, 2022
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43665 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@vweevers@nodejs-github-bot@lpinca@RaisinTen