Skip to content

Conversation

@RafaelGSS
Copy link
Member

cc: @nodejs/security-release

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 28, 2022
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RafaelGSSRafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 28, 2022
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 28, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/43602 ✔ Done loading data for nodejs/node/pull/43602 ----------------------------------- PR info ------------------------------------ Title doc: include CVSS mention (#43602) Author Rafael Gonzaga (@RafaelGSS) Branch RafaelGSS:RafaelGSS-patch-1 -> nodejs:main Labels doc Commits 1 - doc: include CVSS mention Committers 1 - RafaelGSS PR-URL: https://github.com/nodejs/node/pull/43602 Reviewed-By: Vladimir de Turckheim Reviewed-By: Beth Griggs Reviewed-By: Darshan Sen Reviewed-By: Matteo Collina Reviewed-By: Richard Lau ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43602 Reviewed-By: Vladimir de Turckheim Reviewed-By: Beth Griggs Reviewed-By: Darshan Sen Reviewed-By: Matteo Collina Reviewed-By: Richard Lau -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 28 Jun 2022 13:53:36 GMT ✔ Approvals: 5 ✔ - Vladimir de Turckheim (@vdeturckheim): https://github.com/nodejs/node/pull/43602#pullrequestreview-1021787445 ✔ - Beth Griggs (@BethGriggs) (TSC): https://github.com/nodejs/node/pull/43602#pullrequestreview-1021790288 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43602#pullrequestreview-1021796851 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/43602#pullrequestreview-1021799927 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/43602#pullrequestreview-1021830760 ✖ This PR needs to wait 45 more hours to land ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2577727766

@RafaelGSSRafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 30, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 30, 2022
@nodejs-github-botnodejs-github-bot merged commit 56c15f1 into mainJun 30, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 56c15f1

@richardlaurichardlau deleted the RafaelGSS-patch-1 branch June 30, 2022 17:13
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43602 Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]>
@targostargos mentioned this pull request Jul 12, 2022
targos pushed a commit that referenced this pull request Jul 20, 2022
PR-URL: #43602 Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43602 Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]>
@targostargos mentioned this pull request Aug 3, 2022
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43602 Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@RafaelGSS@nodejs-github-bot@mcollina@richardlau@vdeturckheim@BethGriggs@RaisinTen