src,bootstrap: remove NodeMainInstance::registry_#43392
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
All uses of NodeMainInstance::registry_ were removed in nodejs@43d2e24, so this change removes the variable completely. Signed-off-by: Darshan Sen <[email protected]>
nodejs-github-bot added c++ 
This comment was marked as outdated.
This comment was marked as outdated.
cjihrig approved these changes Jun 12, 2022
RaisinTen added the author ready 
tniessen approved these changes Jun 12, 2022
santigimeno approved these changes Jun 12, 2022
This comment was marked as outdated.
This comment was marked as outdated.
joyeecheung approved these changes Jun 13, 2022
jasnell approved these changes Jun 13, 2022
Contributor
Fast-track has been requested by @jasnell. Please 👍 to approve. |
16 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Jun 15, 2022
This comment was marked as outdated.
This comment was marked as outdated.
31 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
34 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Jun 19, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Jun 21, 2022
33 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
32 tasks
Collaborator
nodejs-github-bot commented Jun 28, 2022
23 tasks
RaisinTen added the commit-queue nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Jun 29, 2022
Commit Queue failed- Loading data for nodejs/node/pull/43392 ✔ Done loading data for nodejs/node/pull/43392 ----------------------------------- PR info ------------------------------------ Title src,bootstrap: remove `NodeMainInstance::registry_` (#43392) Author Darshan Sen (@RaisinTen) Branch RaisinTen:src,bootstrap/remove-NodeMainInstance-registry_ -> nodejs:main Labels c++, process, fast-track, author ready, needs-ci Commits 1 - src,bootstrap: remove NodeMainInstance::registry_ Committers 1 - Darshan Sen PR-URL: https://github.com/nodejs/node/pull/43392 Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen Reviewed-By: Santiago Gimeno Reviewed-By: Joyee Cheung Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43392 Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen Reviewed-By: Santiago Gimeno Reviewed-By: Joyee Cheung Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 12 Jun 2022 13:20:52 GMT ✔ Approvals: 5 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/43392#pullrequestreview-1003640736 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43392#pullrequestreview-1003645749 ✔ - Santiago Gimeno (@santigimeno): https://github.com/nodejs/node/pull/43392#pullrequestreview-1003648118 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/43392#pullrequestreview-1003985797 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/43392#pullrequestreview-1004606591 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least one collaborator's approval (👍). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-06-28T04:38:55Z: https://ci.nodejs.org/job/node-test-pull-request/44924/ - Querying data for job/node-test-pull-request/44924/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2583705616 |
RaisinTen added commit-queue nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Jun 29, 2022
Commit Queue failed- Loading data for nodejs/node/pull/43392 ✖ Failed to get collaborator info from nodejs/node/README.md Error: Couldn't find ### TSC (Technical Steering Committee) in the README at parseCollaborators (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/collaborators.js:81:11) at getCollaborators (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/collaborators.js:59:21) at processTicksAndRejections (node:internal/process/task_queues:96:5) at async PRData.getCollaborators (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/pr_data.js:74:26) at async Promise.all (index 0) at async PRData.getAll (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/pr_data.js:58:5) at async getMetadata (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/components/metadata.js:18:3) at async main (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/components/git/land.js:200:22)https://github.com/nodejs/node/actions/runs/2583778187 |
aduh95 added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jun 30, 2022
Landed in 08c8e85 |
targos pushed a commit that referenced this pull request Jul 12, 2022
All uses of NodeMainInstance::registry_ were removed in 43d2e24, so this change removes the variable completely. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #43392 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jul 20, 2022
All uses of NodeMainInstance::registry_ were removed in 43d2e24, so this change removes the variable completely. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #43392 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
All uses of NodeMainInstance::registry_ were removed in 43d2e24, so this change removes the variable completely. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #43392 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
All uses of NodeMainInstance::registry_ were removed in nodejs/node@43d2e24, so this change removes the variable completely. Signed-off-by: Darshan Sen <[email protected]> PR-URL: nodejs/node#43392 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All uses of
NodeMainInstance::registry_were removed in43d2e24, so this change removes the variable completely.
Signed-off-by: Darshan Sen [email protected]
cc @joyeecheung