test_runner: export `describe` and `it`#43420

MoLow · 2022-06-14T07:59:13Z

also, once #43403 is handled - it can probably be a good idea to implement/export a top-level implementation of before, beforeEach, after, afterEach where the parent test is found using executionAsyncId - the same way it is done in this PR

MoLow · 2022-06-14T08:01:59Z

I would love to recieve initial feedback, before I start working on tests and documentation
CC. @benjamingr

benjamingr · 2022-06-14T09:35:33Z

Initial feedback is positive :) @nodejs/test_runner

lib/internal/test_runner/harness.js

MoLow · 2022-06-14T16:01:08Z

cc @Linkgoron

MoLow · 2022-06-15T07:49:59Z

@cjihrig can you please take a look?

lib/internal/test_runner/harness.js

lib/internal/test_runner/test.js

aduh95

I think we would need to also update the docs.

lib/internal/test_runner/harness.js

lib/internal/test_runner/test.js

lib/internal/test_runner/utils.js

MoLow · 2022-06-19T11:02:06Z

@benjamingr AFAIK this pr is ready for review and landing, if you can please review and ping whom you think might be relevant

nodejs-github-bot · 2022-06-19T15:55:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44732/

nodejs-github-bot · 2022-06-26T08:32:38Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44862/

benjamingr · 2022-06-26T09:16:23Z

@nodejs/build can someone with access to the build machines take a look at the failure?

doc/api/test.md

lib/internal/test_runner/harness.js

lib/internal/test_runner/test.js

doc/api/test.md

MoLow · 2022-06-26T09:50:27Z

@nodejs/build can someone with access to the build machines take a look at the failure?

this seems to be broken for a while https://ci.nodejs.org/job/node-cross-compile/

F3n67u · 2022-06-27T13:23:21Z

FYI，@richardlau is investigating the node-cross-compile failure. I created a issue for this: nodejs/build#2977

nodejs-github-bot · 2022-06-28T05:43:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44930/

nodejs-github-bot · 2022-06-28T08:46:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44933/

nodejs-github-bot · 2022-06-29T07:39:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44952/

PR-URL: #43420 Refs: #43415 Reviewed-By: Benjamin Gruenbaum <[email protected]>

benjamingr · 2022-06-29T09:32:51Z

Landed in e2225ba 🎉

PR-URL: nodejs#43420 Refs: nodejs#43415 Reviewed-By: Benjamin Gruenbaum <[email protected]>

PR-URL: nodejs/node#43420 Refs: nodejs/node#43415 Reviewed-By: Benjamin Gruenbaum <[email protected]>

PR-URL: #43420 Refs: #43415 Reviewed-By: Benjamin Gruenbaum <[email protected]>

@kuriyosh

Notable changes: crypto: * (SEMVER-MINOR) remove Node.js-specific webcrypto extensions (Filip Skokan) #43310 * (SEMVER-MINOR) add CFRG curves to Web Crypto API (Filip Skokan) #42507 * (SEMVER-MINOR) make authTagLength optional for CC20P1305 (Tobias Nießen) #42427 * (SEMVER-MINOR) align webcrypto RSA key import/export with other implementations (Filip Skokan) #42816 deps: * update undici to 5.4.0 (Node.js GitHub Bot) #43262 * update undici to 5.3.0 (Node.js GitHub Bot) #43197 dns: * (SEMVER-MINOR) export error code constants from `dns/promises` (Feng Yu) #43176 doc: * add F3n67u to collaborators (Feng Yu) #43953 * deprecate coercion to integer in process.exit (Daeyeon Jeong) #43738 * (SEMVER-MINOR) deprecate diagnostics_channel object subscribe method (Stephen Belanger) #42714 * add LiviaMedeiros to collaborators (LiviaMedeiros) #43039 * add @kuriyosh to collaborators (Yoshiki Kurihara) #42824 * add RafaelGSS to collaborators (RafaelGSS) #42718 * add @meixg to collaborators (Xuguang Mei) #42576 errors: * (SEMVER-MINOR) add support for cause in aborterror (James M Snell) #41008 esm: * (SEMVER-MINOR) add chaining to loaders (Jacob Smith) #42623 events: * (SEMVER-MINOR) expose CustomEvent on global with CLI flag (Daeyeon Jeong) #43885 * (SEMVER-MINOR) add `CustomEvent` (Daeyeon Jeong) #43514 * (SEMVER-MINOR) propagate abortsignal reason in new AbortError ctor in events (James M Snell) #41008 fs: * (SEMVER-MINOR) propagate abortsignal reason in new AbortSignal constructors (James M Snell) #41008 * (SEMVER-MINOR) make params in writing methods optional (LiviaMedeiros) #42601 * (SEMVER-MINOR) add `read(buffer[, options])` versions (LiviaMedeiros) #42768 http: * (SEMVER-MINOR) add drop request event for http server (theanarkh) #43806 * (SEMVER-MINOR) add diagnostics channel for http client (theanarkh) #43580 * (SEMVER-MINOR) add perf_hooks detail for http request and client (theanarkh) #43361 * (SEMVER-MINOR) add uniqueHeaders option to request and createServer (Paolo Insogna) #41397 http2: * (SEMVER-MINOR) propagate abortsignal reason in new AbortError constructor (James M Snell) #41008 * (SEMVER-MINOR) compat support for array headers (OneNail) #42901 lib: * (SEMVER-MINOR) propagate abortsignal reason in new AbortError constructor in blob (James M Snell) #41008 * (SEMVER-MINOR) add abortSignal.throwIfAborted() (James M Snell) #40951 * (SEMVER-MINOR) improved diagnostics_channel subscribe/unsubscribe (Stephen Belanger) #42714 module: * (SEMVER-MINOR) add isBuiltIn method (hemanth.hm) #43396 module,repl: * (SEMVER-MINOR) support 'node:'-only core modules (Colin Ihrig) #42325 net: * (SEMVER-MINOR) add drop event for net server (theanarkh) #43582 * (SEMVER-MINOR) add ability to reset a tcp socket (pupilTong) #43112 node-api: * (SEMVER-MINOR) emit uncaught-exception on unhandled tsfn callbacks (Chengzhong Wu) #36510 perf_hooks: * (SEMVER-MINOR) add PerformanceResourceTiming (RafaelGSS) #42725 report: * (SEMVER-MINOR) add more heap infos in process report (theanarkh) #43116 src: * (SEMVER-MINOR) add --openssl-legacy-provider option (Daniel Bevenius) #40478 * (SEMVER-MINOR) define fs.constants.S_IWUSR & S_IRUSR for Win (Liviu Ionescu) #42757 src,doc,test: * (SEMVER-MAJOR) add --openssl-shared-config option (Daniel Bevenius) #43124 stream: * (SEMVER-MINOR) use cause options in AbortError constructors (James M Snell) #41008 * (SEMVER-MINOR) add iterator helper find (Nitzan Uziely) #41849 * (SEMVER-MINOR) add writableAborted (Robert Nagy) #40802 test: * (SEMVER-MINOR) add initial test module (Colin Ihrig) #42325 test_runner: * (SEMVER-MINOR) expose `describe` and `it` (Moshe Atlow) #43420 * (SEMVER-MINOR) add initial CLI runner (Colin Ihrig) #42658 * (SEMVER-MINOR) support 'only' tests (Colin Ihrig) #42514 timers: * (SEMVER-MINOR) propagate signal.reason in awaitable timers (James M Snell) #41008 util: * (SEMVER-MINOR) add tokens to parseArgs (John Gee) #43459 * (SEMVER-MINOR) add parseArgs module (Benjamin Coe) #42675 v8: * (SEMVER-MINOR) add v8.startupSnapshot utils (Joyee Cheung) #43329 * (SEMVER-MINOR) export more fields in getHeapStatistics (theanarkh) #42784 worker: * (SEMVER-MINOR) add hasRef() to MessagePort (Darshan Sen) #42849 PR-URL: TODO

PR-URL: nodejs/node#43420 Refs: nodejs/node#43415 Reviewed-By: Benjamin Gruenbaum <[email protected]>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. test_runner Issues and PRs related to the test runner subsystem. labels Jun 14, 2022

MoLow changed the title ~~test_runner: expose describe and it~~test_runner: export describe and itJun 14, 2022

jasnell reviewed Jun 14, 2022
View reviewed changes

lib/internal/test_runner/harness.js Outdated Show resolvedHide resolved

MoLow force-pushed the test-runner-describe-it branch from e9ea260 to 6a8249eCompare June 14, 2022 19:24

MoLow force-pushed the test-runner-describe-it branch from 6a8249e to 561565dCompare June 15, 2022 13:38

ljharb reviewed Jun 16, 2022
View reviewed changes

aduh95 reviewed Jun 17, 2022
View reviewed changes

lib/internal/test_runner/harness.js Outdated Show resolvedHide resolved
lib/internal/test_runner/test.js Outdated Show resolvedHide resolved
lib/internal/test_runner/test.js Outdated Show resolvedHide resolved
lib/internal/test_runner/utils.js Outdated Show resolvedHide resolved

MoLow mentioned this pull request Jun 19, 2022
--findRelatedTests for node:test #42992
Closed

MoLow requested a review from ljharb June 19, 2022 12:17

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2022

github-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2022

Linkgoron added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 26, 2022

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2022

benjamingr approved these changes Jun 26, 2022
View reviewed changes

github-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2022

aduh95 reviewed Jun 26, 2022
View reviewed changes

MoLow added 2 commits June 26, 2022 12:53

test_runner: expose describe and it
12537ab

fix
591cba3

richardlau mentioned this pull request Jun 27, 2022
cross-compiler-rhel8-armv7-gcc-8-glibc-2.28: No space left on device nodejs/build#2977
Closed

github-actionsbot mentioned this pull request Jun 28, 2022
CI Reliability 2022-06-28 nodejs/reliability#314
Open
32 tasks

github-actionsbot mentioned this pull request Jun 29, 2022
CI Reliability 2022-06-29 nodejs/reliability#315
Open
23 tasks

benjamingr pushed a commit that referenced this pull request Jun 29, 2022
test_runner: expose describe and it
e2225ba
PR-URL: #43420 Refs: #43415 Reviewed-By: Benjamin Gruenbaum <[email protected]>

benjamingr closed this Jun 29, 2022

MoLow deleted the test-runner-describe-it branch July 5, 2022 11:37

mabaasit pushed a commit to mabaasit/node that referenced this pull request Jul 6, 2022
test_runner: expose describe and it
f8ec3eb
PR-URL: nodejs#43420 Refs: nodejs#43415 Reviewed-By: Benjamin Gruenbaum <[email protected]>

aduh95 pushed a commit to aduh95/node-core-test that referenced this pull request Jul 8, 2022
test_runner: expose describe and it
354cc23
PR-URL: nodejs/node#43420 Refs: nodejs/node#43415 Reviewed-By: Benjamin Gruenbaum <[email protected]>

aduh95 pushed a commit to aduh95/node-core-test that referenced this pull request Jul 9, 2022
feat: expose describe and it
56d86fa
PR-URL: nodejs/node#43420 Refs: nodejs/node#43415 Reviewed-By: Benjamin Gruenbaum <[email protected]>

aduh95 pushed a commit to aduh95/node-core-test that referenced this pull request Jul 9, 2022
feat: expose describe and it
e29cd3f
PR-URL: nodejs/node#43420 Refs: nodejs/node#43415 Reviewed-By: Benjamin Gruenbaum <[email protected]>

targos pushed a commit that referenced this pull request Jul 12, 2022
test_runner: expose describe and it
4bda6e0
PR-URL: #43420 Refs: #43415 Reviewed-By: Benjamin Gruenbaum <[email protected]>

targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Jul 12, 2022

targos mentioned this pull request Jul 12, 2022
v18.6.0 release proposal #43789
Merged

aduh95 added dont-land-on-v14.x labels Jul 18, 2022

targos removed the dont-land-on-v16.x label Jul 31, 2022

targos pushed a commit that referenced this pull request Jul 31, 2022
test_runner: expose describe and it
61a2ddc
PR-URL: #43420 Refs: #43415 Reviewed-By: Benjamin Gruenbaum <[email protected]>

targos mentioned this pull request Aug 2, 2022
v16.17.0 release proposal #44098
Merged

guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
test_runner: expose describe and it
419cf50
PR-URL: nodejs/node#43420 Refs: nodejs/node#43415 Reviewed-By: Benjamin Gruenbaum <[email protected]>

himself65 mentioned this pull request Jun 29, 2023
Incosistant result between test and it in node:test#48582
Closed

Uh oh!

test_runner: export describe and it#43420

test_runner: export describe and it#43420

Uh oh!

Conversation

MoLow commented Jun 14, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MoLow commented Jun 14, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benjamingr commented Jun 14, 2022

Uh oh!

Uh oh!

MoLow commented Jun 14, 2022

Uh oh!

MoLow commented Jun 15, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aduh95 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MoLow commented Jun 19, 2022

Uh oh!

nodejs-github-bot commented Jun 19, 2022

Uh oh!

nodejs-github-bot commented Jun 26, 2022

Uh oh!

benjamingr commented Jun 26, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MoLow commented Jun 26, 2022

Uh oh!

F3n67u commented Jun 27, 2022

Uh oh!

nodejs-github-bot commented Jun 28, 2022

Uh oh!

nodejs-github-bot commented Jun 28, 2022

Uh oh!

nodejs-github-bot commented Jun 29, 2022

Uh oh!

benjamingr commented Jun 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

test_runner: export `describe` and `it`#43420

test_runner: export `describe` and `it`#43420

MoLow commented Jun 14, 2022•
edited
Loading

MoLow commented Jun 14, 2022•
edited
Loading