Skip to content

test: improve coverage for load hooks#43374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 2 commits into from
Jun 18, 2022
Merged

test: improve coverage for load hooks #43374

nodejs-github-bot merged 2 commits into from
Jun 18, 2022

Conversation

@aduh95
Copy link
Contributor

@aduh95aduh95 commented Jun 11, 2022

Refs: #43363 (comment)

/cc @nodejs/loaders

@nodejs-github-botnodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 11, 2022
@aduh95aduh95 mentioned this pull request Jun 11, 2022
Merged
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 12, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 12, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 12, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44458/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 13, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44500/

GeoffreyBooth
GeoffreyBooth reviewed Jun 13, 2022
View reviewed changes
JakobJingleheimer
JakobJingleheimer approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@JakobJingleheimerJakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Could you add description comments to the blocks in test-esm-loader-thenable.mjs (similar to test-esm-loader-chaining.mjs)

This was referenced Jun 14, 2022
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 15, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44574/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 15, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44582/

This was referenced Jun 16, 2022
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 17, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44643/

@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 17, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 17, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 17, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44647/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 17, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44657/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 17, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44662/

@github-actionsgithub-actionsbot mentioned this pull request Jun 18, 2022
Open
34 tasks
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 18, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 18, 2022
@nodejs-github-botnodejs-github-bot merged commit 29236b5 into nodejs:mainJun 18, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 18, 2022

Landed in 29236b5

@F3n67uF3n67u mentioned this pull request Jun 18, 2022
Open
@aduh95aduh95 deleted the load-hook-thenable-coverage branch June 18, 2022 08:30
This was referenced Jun 19, 2022
Open
Open
targos pushed a commit that referenced this pull request Jul 12, 2022
@aduh95@targos
test: improve coverage for load hooks
48ae00c
Refs: #43363 (comment) PR-URL: #43374 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
@targostargos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 19, 2022
@aduh95@targos
test: improve coverage for load hooks
24dfd70
Refs: #43363 (comment) PR-URL: #43374 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@aduh95@targos
test: improve coverage for load hooks
222a6e9
Refs: #43363 (comment) PR-URL: #43374 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
@targostargos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@aduh95@guangwong
test: improve coverage for load hooks
02f9e05
Refs: nodejs/node#43363 (comment) PR-URL: nodejs/node#43374 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes

@JakobJingleheimerJakobJingleheimerJakobJingleheimer approved these changes

@marsonyamarsonyamarsonya approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.esmIssues and PRs related to the ECMAScript Modules implementation.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aduh95@nodejs-github-bot@jasnell@GeoffreyBooth@JakobJingleheimer@marsonya