Skip to content

Conversation

@nodejs-github-bot
Copy link
Collaborator

This is an automated update of eslint to 8.18.0.

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 19, 2022
@lpincalpincaforce-pushed the actions/tools-update-eslint branch from 2fc868f to b48b9f0CompareJune 19, 2022 07:43
@aduh95
Copy link
Contributor

i think this need to be one commit, otherwise there's going to be at least one commit that doesn't pass the CI on main

and the tests, but is still one logical change. All tests should always pass
when each individual commit lands on one of the `nodejs/node` branches.

@TrottTrott added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jun 19, 2022
Copy link
Member

@TrottTrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@TrottTrott added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 19, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2022
@nodejs-github-bot
Copy link
CollaboratorAuthor

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 19, 2022
@nodejs-github-bot
Copy link
CollaboratorAuthor

@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 19, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 19, 2022
@nodejs-github-botnodejs-github-bot merged commit 9c3c66b into mainJun 19, 2022
@nodejs-github-bot
Copy link
CollaboratorAuthor

Landed in 9c3c66b

@TrottTrott deleted the actions/tools-update-eslint branch June 19, 2022 22:06
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43479 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@targostargos mentioned this pull request Jul 12, 2022
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43479 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43479 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@targostargos mentioned this pull request Aug 3, 2022
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43479 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.fast-trackPRs that do not need to wait for 48 hours to land.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@nodejs-github-bot@aduh95@Trott@lpinca@targos@cjihrig@VoltrexKeyva