test: mark test-worker-http2-stream-terminate flaky on Windows#43425
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The test is causing a lot of CI failures, so I'd say that we should mark this test flaky until someone comes up with a proper fix. Refs: nodejs#43084 Signed-off-by: Darshan Sen <[email protected]>
nodejs-github-bot added needs-ci 
This comment was marked as outdated.
This comment was marked as outdated.
jasnell approved these changes Jun 14, 2022
RaisinTen added the author ready 
tniessen approved these changes Jun 14, 2022
17 tasks
MemberAuthor
RaisinTen commented Jun 15, 2022
Hmm, the test still runs and fails on Windows: |
RaisinTen removed the author ready 
Member
richardlau commented Jun 15, 2022
@RaisinTen AFAICT it worked and https://ci.nodejs.org/job/node-test-binary-windows-js-suites/15120/RUN_SUBSET=1,nodes=win2012r2-COMPILED_BY-vs2019-x86/ is yellow and not red. https://ci.nodejs.org/job/node-test-binary-windows-js-suites/15120/ failed because https://ci.nodejs.org/job/node-test-binary-windows-js-suites/15120/RUN_SUBSET=2,nodes=win2012r2-COMPILED_BY-vs2019-x86/ failed for a different test, test.parallel/test-worker-heap-snapshot. |
22 tasks
MemberAuthor
RaisinTen commented Jun 16, 2022
Ah, indeed! Thanks for the clarification @richardlau. :) |
This comment was marked as outdated.
This comment was marked as outdated.
RaisinTen added the author ready This comment was marked as outdated.
This comment was marked as outdated.
31 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
nodejs-github-bot commented Jun 17, 2022
34 tasks
aduh95 added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jun 18, 2022
Landed in 61c7103 |
RaisinTen deleted the test/mark-test-worker-http2-stream-terminate-flaky-on-win branch 30 tasks
targos pushed a commit that referenced this pull request Jul 12, 2022
The test is causing a lot of CI failures, so I'd say that we should mark this test flaky until someone comes up with a proper fix. Refs: #43084 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #43425 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Jul 18, 2022
The test is causing a lot of CI failures, so I'd say that we should mark this test flaky until someone comes up with a proper fix. Refs: #43084 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #43425 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
The test is causing a lot of CI failures, so I'd say that we should mark this test flaky until someone comes up with a proper fix. Refs: #43084 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #43425 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
The test is causing a lot of CI failures, so I'd say that we should mark this test flaky until someone comes up with a proper fix. Refs: nodejs/node#43084 Signed-off-by: Darshan Sen <[email protected]> PR-URL: nodejs/node#43425 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test is causing a lot of CI failures, so I'd say that we should mark
this test flaky until someone comes up with a proper fix.
Refs: #43084
Signed-off-by: Darshan Sen [email protected]