doc: remove openssl 1.x reference#43734
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Jul 8, 2022
Review requested:
|
Contributor
Fast-track has been requested by @RafaelGSS. Please 👍 to approve. |
richardlau approved these changes Jul 8, 2022
Member
richardlau left a comment
richardlau left a comment There was a problem hiding this comment.
There's a bullet point at the beginning of this doc referring to Node.js 12 that should also go, but that could be done separately.
Uh oh!
There was an error while loading. Please reload this page.
RafaelGSSforce-pushed the maintaining-openssl-3-update branch from f03862e to 00cc428Comparerichardlau approved these changes Jul 8, 2022
aduh95 reviewed Jul 8, 2022
Uh oh!
There was an error while loading. Please reload this page.
lpinca approved these changes Jul 8, 2022
tniessen approved these changes Jul 8, 2022
RafaelGSSforce-pushed the maintaining-openssl-3-update branch from 00cc428 to 538f238Compareaduh95 approved these changes Jul 8, 2022
lpinca added a commit to lpinca/node that referenced this pull request Jul 9, 2022
lpinca added a commit to lpinca/node that referenced this pull request Jul 9, 2022
RaisinTen approved these changes Jul 10, 2022
RafaelGSS added the commit-queue 
nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Jul 10, 2022
Commit Queue failed- Loading data for nodejs/node/pull/43734 ✔ Done loading data for nodejs/node/pull/43734 ----------------------------------- PR info ------------------------------------ Title doc: remove openssl 1.x reference (#43734) Author Rafael Gonzaga (@RafaelGSS) Branch RafaelGSS:maintaining-openssl-3-update -> nodejs:main Labels doc, fast-track, dont-land-on-v14.x, dont-land-on-v16.x Commits 1 - doc: remove openssl 1.x reference Committers 1 - RafaelGSS PR-URL: https://github.com/nodejs/node/pull/43734 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: Antoine du Hamel Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43734 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: Antoine du Hamel Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 08 Jul 2022 14:42:57 GMT ✔ Approvals: 5 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/43734#pullrequestreview-1033024170 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43734#pullrequestreview-1033067101 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43734#pullrequestreview-1033118885 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/43734#pullrequestreview-1033391893 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43734#pullrequestreview-1033641795 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2646357011 |
aduh95 added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jul 11, 2022
Landed in 45a4fdb |
nodejs-github-bot pushed a commit that referenced this pull request Jul 12, 2022
Refs: #43734 (review) PR-URL: #43744 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43734 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
Refs: #43734 (review) PR-URL: #43744 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSSL 1.x is only used in v16 and v14. To avoid confusions I recommend removing OpenSSL 1.x references from main and v18.x.
Note: these references will still exist in v16.x and v14.x branches