tools: refactor tools/license2rtf to ESM

[F3n67u]

This pr reimplement #43101: refactor license2rtf.js to ESM.

The last pr(43101) is reverted by #43214 because it causes windows ci failure.

Refs: #43213

Windows

Before the fix

C:\Users\Administrator\dev\node>git log -1 commit c9f5078d8cb601624caeec656823445475050bc1 (HEAD -> master) Author: Feng <[email protected]> Date: Sun May 29 12:14:26 2022 +0800 Revert "Revert "tools: refactor `tools/license2rtf` to ESM"" This reverts commit 331088f4a450e29f3ea8a28a9f98ccc9f8951386. C:\Users\Administrator\dev\node>git --no-pager diff C:\Users\Administrator\dev\node>.\Release\node.exe tools\license2rtf.mjs < LICENSE > license.rtf C:\Users\Administrator\dev\node>echo Exit Code is %errorlevel% Exit Code is 13

The exit code of .\Release\node.exe tools\license2rtf.mjs < LICENSE > license.rtf command is 13 which cause windows ci failure: Failed to generate license.rtf(#43213).

The errorlevel variable check of windows build is at:

node/vcbuild.bat

Line 428 in ca0044b

iferrorlevel1echo Failed to generate license.rtf&goto exit

After fix

C:\Users\Administrator\dev\node>git --no-pager diff diff --git a/tools/license2rtf.mjs b/tools/license2rtf.mjs index 0772b161ed..6f07e57c7f 100644 --- a/tools/license2rtf.mjs +++ b/tools/license2rtf.mjs @@ -289,11 +289,16 @@ class RtfGenerator extends Stream{stdin.setEncoding('utf-8');stdin.resume(); -await pipeline( - stdin, - new LineSplitter(), - new ParagraphParser(), - new Unwrapper(), - new RtfGenerator(), - stdout, -); +async functionmain(){+ await pipeline( + stdin, + new LineSplitter(), + new ParagraphParser(), + new Unwrapper(), + new RtfGenerator(), + stdout, + ); +} + +main().catch(console.error); + C:\Users\Administrator\dev\node>.\Release\node.exe tools\license2rtf.mjs < LICENSE > license.rtf C:\Users\Administrator\dev\node>echo Exit Code is %errorlevel% Exit Code is 0

The exit code of .\Release\node.exe tools\license2rtf.mjs < LICENSE > license.rtf command is 0.

MacOS

Before the fix

$ git --no-pager log -1 commit 255c643e136a1aa11c4cbb6667f76624e85b4721 (HEAD -> master, revert-revert-esm-license2rtf) Author: Feng Yu <[email protected]> Date: Sun May 29 12:19:04 2022 +0800 Revert "Revert "tools: refactor `tools/license2rtf` to ESM"" This reverts commit 331088f4a450e29f3ea8a28a9f98ccc9f8951386. $ ./node tools/license2rtf.mjs < LICENSE > license.rtf $ echo$? 13

The exit code of ./node tools/license2rtf.mjs < LICENSE > license.rtf command is 13.

After fix

$ git --no-pager diff diff --git a/tools/license2rtf.mjs b/tools/license2rtf.mjs index 0772b161ed..4cdca33b60 100644 --- a/tools/license2rtf.mjs +++ b/tools/license2rtf.mjs @@ -289,11 +289,15 @@ class RtfGenerator extends Stream{stdin.setEncoding('utf-8');stdin.resume(); -await pipeline( - stdin, - new LineSplitter(), - new ParagraphParser(), - new Unwrapper(), - new RtfGenerator(), - stdout, -); +async functionmain(){+ await pipeline( + stdin, + new LineSplitter(), + new ParagraphParser(), + new Unwrapper(), + new RtfGenerator(), + stdout, + ); +} + +main().catch(console.error); $ ./node tools/license2rtf.mjs < LICENSE > license.rtf $ echo$? 0

The exit code of ./node tools/license2rtf.mjs < LICENSE > license.rtf command is 0.

[F3n67u]

I leave the revert-revert commit untouched intentionally to make code review easier. so the commit message ci check will fail.

once this pr has enough approval, I will squash those two commits to one commit.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/44224/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45007/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45049/

[F3n67u]

Please help to trigger another ci run.

The last ci failure is caused by flaky test-stream-finished, this test has already been fixed in main branch.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45060/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45064/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45068/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/43232 ✔ Done loading data for nodejs/node/pull/43232 ----------------------------------- PR info ------------------------------------ Title tools: refactor `tools/license2rtf` to ESM (#43232) Author Feng Yu (@F3n67u) Branch F3n67u:revert-revert-esm-license2rtf -> nodejs:main Labels windows, build, tools, author ready, needs-ci Commits 1 - tools: refactor `tools/license2rtf` to ESM Committers 1 - Feng Yu PR-URL: https://github.com/nodejs/node/pull/43232 Refs: https://github.com/nodejs/node/issues/43213 Reviewed-By: Darshan Sen Reviewed-By: LiviaMedeiros ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43232 Refs: https://github.com/nodejs/node/issues/43213 Reviewed-By: Darshan Sen Reviewed-By: LiviaMedeiros -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - tools: refactor `tools/license2rtf` to ESM ℹ This PR was created on Sun, 29 May 2022 04:51:00 GMT ✔ Approvals: 2 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43232#pullrequestreview-988629243 ✔ - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/43232#pullrequestreview-995051304 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-07-03T11:28:31Z: https://ci.nodejs.org/job/node-test-pull-request/45068/ - Querying data for job/node-test-pull-request/45068/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/2605126551

[F3n67u]

Please help to land this pr, thanks in advance

[LiviaMedeiros]

Landed in a420995