Skip to content

Revert "tools: refactor tools/license2rtf to ESM"#43214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
May 26, 2022
Merged

Revert "tools: refactor tools/license2rtf to ESM" #43214

nodejs-github-bot merged 1 commit into from
May 26, 2022

Conversation

@richardlau
Copy link
Member

@richardlaurichardlau commented May 26, 2022•
edited
Loading

This reverts commit 30cb1bf.

Fixes: #43213
Refs: #43101

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels May 26, 2022
@richardlaurichardlau added request-ci Add this label to start a Jenkins CI on a PR. windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. needs-ci PRs that need a full CI run. revert PRs that revert previously landed PRs. and removed windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. needs-ci PRs that need a full CI run. labels May 26, 2022
@richardlaurichardlau mentioned this pull request May 26, 2022
Closed
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 26, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 26, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44171/

@richardlau
Copy link
MemberAuthor

richardlau commented May 26, 2022

I've added dont-land-* labels to #43101 so adding the same here as we don't need to revert if the original doesn't land in the staging branches 🙂.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 26, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44174/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 26, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44177/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 26, 2022•
edited by richardlau
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/44178/ (✔️ 🎉 )

@richardlaurichardlau added the fast-track PRs that do not need to wait for 48 hours to land. label May 26, 2022
@github-actions
Copy link
Contributor

github-actionsbot commented May 26, 2022

Fast-track has been requested by @richardlau. Please 👍 to approve.

@richardlaurichardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label May 26, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 26, 2022
@nodejs-github-botnodejs-github-bot merged commit 331088f into nodejs:masterMay 26, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 26, 2022

Landed in 331088f

@richardlaurichardlau deleted the revert43101 branch May 26, 2022 16:09
@richardlaurichardlau mentioned this pull request May 27, 2022
Merged
This was referenced May 28, 2022
Open
Open
@F3n67uF3n67u mentioned this pull request May 29, 2022
Closed
This was referenced May 30, 2022
Open
Open
Open
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
@richardlau@danielleadams
Revert "tools: refactor tools/license2rtf to ESM"
47fd3c1
This reverts commit 30cb1bf. PR-URL: #43214Fixes: #43213 Refs: #43101 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Jun 11, 2022
Merged
@RafaelGSSRafaelGSS mentioned this pull request Oct 14, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes

@BethGriggsBethGriggsBethGriggs approved these changes

@RaisinTenRaisinTenRaisinTen approved these changes

@LiviaMedeirosLiviaMedeirosLiviaMedeiros approved these changes

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.revertPRs that revert previously landed PRs.toolsIssues and PRs related to the tools directory.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows build break: Failed to generate license.rtf

6 participants

@richardlau@nodejs-github-bot@Trott@BethGriggs@RaisinTen@LiviaMedeiros