bootstrap: move global initialization to JS#43625
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Jun 30, 2022
Review requested:
|
nodejs-github-bot added c++ 
alenakhineika changed the title 
alenakhineikaforce-pushed the move-global-to-globalthis branch from 1537ca4 to 41933c5Compare
This comment was marked as resolved.
This comment was marked as resolved.
aduh95 approved these changes Jun 30, 2022
aduh95 added author ready 
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Jun 30, 2022
legendecas approved these changes Jun 30, 2022
Collaborator
nodejs-github-bot commented Jul 3, 2022
23 tasks
juanarbol approved these changes Jul 4, 2022
Collaborator
nodejs-github-bot commented Jul 4, 2022
Collaborator
nodejs-github-bot commented Jul 7, 2022
16 tasks
aduh95 added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jul 8, 2022
Landed in 680dd7c |
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43625 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
targos pushed a commit that referenced this pull request Jul 20, 2022
PR-URL: #43625 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43625 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43625 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
globalThis.global = globalThis;to JS. Addresses TODO created by @joyeecheung.