Skip to content

lib: fix TODO in freeze_intrinsics#43472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jun 27, 2022
Merged

lib: fix TODO in freeze_intrinsics#43472

nodejs-github-bot merged 1 commit into from
Jun 27, 2022

Conversation

@aduh95
Copy link
Contributor

@aduh95aduh95 commented Jun 18, 2022

No description provided.

@aduh95aduh95 requested a review from guybedfordJune 18, 2022 16:04
@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 18, 2022
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 18, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 18, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44705/

@github-actionsgithub-actionsbot mentioned this pull request Jun 19, 2022
Open
30 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 19, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44715/

@github-actionsgithub-actionsbot mentioned this pull request Jun 20, 2022
Open
36 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 20, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44770/

This was referenced Jun 21, 2022
Open
Open
Open
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 27, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 27, 2022
@nodejs-github-botnodejs-github-bot merged commit 411fb21 into nodejs:mainJun 27, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 27, 2022

Landed in 411fb21

@aduh95aduh95 deleted the freeze-intrinsics-todo branch June 27, 2022 16:27
targos pushed a commit that referenced this pull request Jul 12, 2022
@aduh95@targos
lib: fix TODO in freeze_intrinsics
deaf4bb
PR-URL: #43472 Reviewed-By: Guy Bedford <[email protected]>
@targostargos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
@aduh95@targos
lib: fix TODO in freeze_intrinsics
5fdc145
PR-URL: #43472 Reviewed-By: Guy Bedford <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@aduh95@targos
lib: fix TODO in freeze_intrinsics
a97d0ba
PR-URL: #43472 Reviewed-By: Guy Bedford <[email protected]>
@targostargos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@aduh95@guangwong
lib: fix TODO in freeze_intrinsics
20e8ac5
PR-URL: nodejs/node#43472 Reviewed-By: Guy Bedford <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guybedfordguybedfordguybedford approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aduh95@nodejs-github-bot@guybedford