process: refactor to use more primordials

PR-URL: #36212 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Author: aduh95

lib/internal/process/per_thread.js

@@ -6,18 +6,21 @@
 
 const{
  ArrayIsArray,
+ ArrayPrototypeMap,
+ ArrayPrototypePush,
+ ArrayPrototypeSplice,
  BigUint64Array,
  Float64Array,
  NumberMAX_SAFE_INTEGER,
- ObjectDefineProperties,
  ObjectDefineProperty,
  ObjectFreeze,
-ObjectGetOwnPropertyDescriptors,
+ReflectApply,
  RegExpPrototypeTest,
- Set,
- SetPrototype,
- SetPrototypeHas,
+ SafeSet,
+ StringPrototypeEndsWith,
  StringPrototypeReplace,
+ StringPrototypeSlice,
+ StringPrototypeStartsWith,
  Uint32Array,
 }=primordials;
 
@@ -94,7 +97,7 @@ function wrapProcessMethods(binding){
 }=binding;
 
 function_rawDebug(...args){
-binding._rawDebug(format.apply(null,args));
+binding._rawDebug(ReflectApply(format,null,args));
 }
 
 // Create the argument array that will be passed to the native function.
@@ -256,31 +259,31 @@ function buildAllowedFlags(){
 constallowedNodeEnvironmentFlags=[];
 for(const[name,info]ofoptions){
 if(info.envVarSettings===kAllowedInEnvironment){
-allowedNodeEnvironmentFlags.push(name);
+ArrayPrototypePush(allowedNodeEnvironmentFlags,name);
 }
 }
 
 for(const[from,expansion]ofaliases){
 letisAccepted=true;
 for(consttoofexpansion){
-if(!to.startsWith('-')||to==='--')continue;
+if(!StringPrototypeStartsWith(to,'-')||to==='--')continue;
 constrecursiveExpansion=aliases.get(to);
 if(recursiveExpansion){
 if(recursiveExpansion[0]===to)
-recursiveExpansion.splice(0,1);
-expansion.push(...recursiveExpansion);
+ArrayPrototypeSplice(recursiveExpansion,0,1);
+ArrayPrototypePush(expansion,...recursiveExpansion);
 continue;
 }
 isAccepted=options.get(to).envVarSettings===kAllowedInEnvironment;
 if(!isAccepted)break;
 }
 if(isAccepted){
 letcanonical=from;
-if(canonical.endsWith('='))
-canonical=canonical.substr(0,canonical.length-1);
-if(canonical.endsWith(' <arg>'))
-canonical=canonical.substr(0,canonical.length-4);
-allowedNodeEnvironmentFlags.push(canonical);
+if(StringPrototypeEndsWith(canonical,'='))
+canonical=StringPrototypeSlice(canonical,0,canonical.length-1);
+if(StringPrototypeEndsWith(canonical,' <arg>'))
+canonical=StringPrototypeSlice(canonical,0,canonical.length-4);
+ArrayPrototypePush(allowedNodeEnvironmentFlags,canonical);
 }
 }
 
@@ -289,14 +292,10 @@ function buildAllowedFlags(){
 
 // Save these for comparison against flags provided to
 // process.allowedNodeEnvironmentFlags.has() which lack leading dashes.
-// Avoid interference w/ user code by flattening `Set.prototype` into
-// each object.
-constnodeFlags=ObjectDefineProperties(
-newSet(allowedNodeEnvironmentFlags.map(trimLeadingDashes)),
-ObjectGetOwnPropertyDescriptors(SetPrototype)
-);
-
-classNodeEnvironmentFlagsSetextendsSet{
+constnodeFlags=newSafeSet(ArrayPrototypeMap(allowedNodeEnvironmentFlags,
+trimLeadingDashes));
+
+classNodeEnvironmentFlagsSetextendsSafeSet{
 constructor(...args){
 super(...args);
 
@@ -328,9 +327,9 @@ function buildAllowedFlags(){
 key=StringPrototypeReplace(key,replaceUnderscoresRegex,'-');
 if(RegExpPrototypeTest(leadingDashesRegex,key)){
 key=StringPrototypeReplace(key,trailingValuesRegex,'');
-returnSetPrototypeHas(this,key);
+returnsuper.has(key);
 }
-returnSetPrototypeHas(nodeFlags,key);
+returnnodeFlags.has(key);
 }
 returnfalse;
 }

lib/internal/process/promises.js

@@ -1,9 +1,11 @@
 'use strict';
 
 const{
+ ArrayPrototypePush,
+ ArrayPrototypeShift,
  Error,
  ObjectDefineProperty,
-WeakMap,
+SafeWeakMap,
 }=primordials;
 
 const{
@@ -25,7 +27,7 @@ const{
 // *Must* match Environment::TickInfo::Fields in src/env.h.
 constkHasRejectionToWarn=1;
 
-constmaybeUnhandledPromises=newWeakMap();
+constmaybeUnhandledPromises=newSafeWeakMap();
 constpendingUnhandledRejections=[];
 constasyncHandledRejections=[];
 letlastPromiseId=0;
@@ -121,7 +123,7 @@ function unhandledRejection(promise, reason){
 domain: process.domain
 });
 // This causes the promise to be referenced at least for one tick.
-pendingUnhandledRejections.push(promise);
+ArrayPrototypePush(pendingUnhandledRejections,promise);
 setHasRejectionToWarn(true);
 }
 
@@ -137,7 +139,7 @@ function handledRejection(promise){
 `asynchronously (rejection id: ${uid})`);
 warning.name='PromiseRejectionHandledWarning';
 warning.id=uid;
-asyncHandledRejections.push({ promise, warning });
+ArrayPrototypePush(asyncHandledRejections,{ promise, warning });
 setHasRejectionToWarn(true);
 return;
 }
@@ -178,15 +180,15 @@ function processPromiseRejections(){
 letmaybeScheduledTicksOrMicrotasks=asyncHandledRejections.length>0;
 
 while(asyncHandledRejections.length>0){
-const{ promise, warning }=asyncHandledRejections.shift();
+const{ promise, warning }=ArrayPrototypeShift(asyncHandledRejections);
 if(!process.emit('rejectionHandled',promise)){
 process.emitWarning(warning);
 }
 }
 
 letlen=pendingUnhandledRejections.length;
 while(len--){
-constpromise=pendingUnhandledRejections.shift();
+constpromise=ArrayPrototypeShift(pendingUnhandledRejections);
 constpromiseInfo=maybeUnhandledPromises.get(promise);
 if(promiseInfo===undefined){
 continue;

lib/internal/process/signal.js

@@ -1,7 +1,8 @@
 'use strict';
 
 const{
- Map,
+ FunctionPrototypeBind,
+ SafeMap,
 }=primordials;
 
 const{
@@ -11,7 +12,7 @@ const{
 const{ signals }=internalBinding('constants').os;
 
 letSignal;
-constsignalWraps=newMap();
+constsignalWraps=newSafeMap();
 
 functionisSignal(event){
 returntypeofevent==='string'&&signals[event]!==undefined;
@@ -26,7 +27,7 @@ function startListeningIfSignal(type){
 
 wrap.unref();
 
-wrap.onsignal=process.emit.bind(process,type,type);
+wrap.onsignal=FunctionPrototypeBind(process.emit,process,type,type);
 
 constsignum=signals[type];
 consterr=wrap.start(signum);