Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
process: refactor to use more primordials#36212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot commented Nov 21, 2020
Trott commented Nov 23, 2020 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Trott commented Nov 24, 2020
Benchmark results seem fine: |
PR-URL: nodejs#36212 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Rich Trott <[email protected]>
642f480 to d4501b1CompareTrott commented Nov 24, 2020
Landed in d4501b1 |
PR-URL: #36212 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Rich Trott <[email protected]>
aduh95 commented Dec 28, 2020
This should not land to LTS lines unless #36660 is included. |
aduh95 commented Jan 7, 2021
Does anyone on this thread want to review #36660 so it can be included in the next v15 release? This PR has leaked $ node -p 'Object.getPrototypeOf(process.allowedNodeEnvironmentFlags)'SafeSet [Set]{} |
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes