stream: ensure writable.destroy() emits error once

Prevent the `'error'` event from being emitted multiple times if `writable.destroy()` is called with an error before the `_destroy()` callback is called. Emit the first error, discard all others. PR-URL: #26057 Backport-PR-URL: #28000Fixes: #26015 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: lpinca

lib/internal/streams/destroy.js

@@ -10,10 +10,15 @@ function destroy(err, cb){
 if(readableDestroyed||writableDestroyed){
 if(cb){
 cb(err);
-}elseif(err&&
-(!this._writableState||!this._writableState.errorEmitted)){
-process.nextTick(emitErrorNT,this,err);
+}elseif(err){
+if(!this._writableState){
+process.nextTick(emitErrorNT,this,err);
+}elseif(!this._writableState.errorEmitted){
+this._writableState.errorEmitted=true;
+process.nextTick(emitErrorNT,this,err);
+}
 }
+
 returnthis;
 }
 
@@ -31,9 +36,11 @@ function destroy(err, cb){
 
 this._destroy(err||null,(err)=>{
 if(!cb&&err){
-process.nextTick(emitErrorNT,this,err);
-if(this._writableState){
+if(!this._writableState){
+process.nextTick(emitErrorNT,this,err);
+}elseif(!this._writableState.errorEmitted){
 this._writableState.errorEmitted=true;
+process.nextTick(emitErrorNT,this,err);
 }
 }elseif(cb){
 cb(err);

test/parallel/test-stream-writable-destroy.js

@@ -146,6 +146,32 @@ const{inherits } = require('util');
 assert.strictEqual(write.destroyed,true);
 }
 
+{
+constwritable=newWritable({
+destroy: common.mustCall(function(err,cb){
+process.nextTick(cb,newError('kaboom 1'));
+}),
+write(chunk,enc,cb){
+cb();
+}
+});
+
+writable.on('close',common.mustNotCall());
+writable.on('error',common.expectsError({
+type: Error,
+message: 'kaboom 2'
+}));
+
+writable.destroy();
+assert.strictEqual(writable.destroyed,true);
+assert.strictEqual(writable._writableState.errorEmitted,false);
+
+// Test case where `writable.destroy()` is called again with an error before
+// the `_destroy()` callback is called.
+writable.destroy(newError('kaboom 2'));
+assert.strictEqual(writable._writableState.errorEmitted,true);
+}
+
 {
 constwrite=newWritable({
 write(chunk,enc,cb){cb();}