stream: ensure writable.destroy() emits error once#26057
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Prevent the `'error'` event from being emitted multiple times if `writable.destroy()` is called with an error before the `_destroy()` callback is called. Emit the first error, discard all others. Fixes: nodejs#26015
MemberAuthor
lpinca commented Feb 12, 2019
This does not fix the issue for readable only streams. |
Member
addaleax commented Feb 13, 2019
@nodejs/streams |
ZYSzys reviewed Feb 14, 2019
Uh oh!
There was an error while loading. Please reload this page.
MemberAuthor
lpinca commented Mar 2, 2019
cc: @nodejs/streams |
BridgeAR approved these changes Mar 5, 2019
BridgeAR added the author ready 
Member
BridgeAR commented Mar 5, 2019
Should we actually allow calling |
Member
mcollina commented Mar 5, 2019
Yes. This is actually an use case of the API (historically). |
jasnell approved these changes Mar 5, 2019
Member
BridgeAR commented Mar 5, 2019
Landed in 49f1bb9 🎉 |
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 5, 2019
Prevent the `'error'` event from being emitted multiple times if `writable.destroy()` is called with an error before the `_destroy()` callback is called. Emit the first error, discard all others. PR-URL: nodejs#26057Fixes: nodejs#26015 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
Prevent the `'error'` event from being emitted multiple times if `writable.destroy()` is called with an error before the `_destroy()` callback is called. Emit the first error, discard all others. PR-URL: nodejs#26057Fixes: nodejs#26015 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
Prevent the `'error'` event from being emitted multiple times if `writable.destroy()` is called with an error before the `_destroy()` callback is called. Emit the first error, discard all others. PR-URL: #26057Fixes: #26015 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced May 29, 2019
3 tasks
lpinca added a commit to lpinca/node that referenced this pull request Jun 1, 2019
Prevent the `'error'` event from being emitted multiple times if `writable.destroy()` is called with an error before the `_destroy()` callback is called. Emit the first error, discard all others. PR-URL: nodejs#26057 Backport-PR-URL: nodejs#28000Fixes: nodejs#26015 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 19, 2019
Prevent the `'error'` event from being emitted multiple times if `writable.destroy()` is called with an error before the `_destroy()` callback is called. Emit the first error, discard all others. PR-URL: #26057 Backport-PR-URL: #28000Fixes: #26015 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent the
'error'event from being emitted multiple times ifwritable.destroy()is called with an error before the_destroy()callback is called.
Emit the first error, discard all others.
Fixes: #26015
Refs: #20745 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes