zlib: refactor to use more primordials

PR-URL: #36347 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Author: aduh95

lib/zlib.js

@@ -23,7 +23,10 @@
 
 const{
  ArrayBuffer,
+ ArrayPrototypeMap,
+ ArrayPrototypePush,
  Error,
+ FunctionPrototypeBind,
  MathMax,
  NumberIsFinite,
  NumberIsNaN,
@@ -33,7 +36,9 @@ const{
  ObjectGetPrototypeOf,
  ObjectKeys,
  ObjectSetPrototypeOf,
+ ReflectApply,
  Symbol,
+ TypedArrayPrototypeFill,
  Uint32Array,
 }=primordials;
 
@@ -124,7 +129,7 @@ function zlibBufferOnData(chunk){
 if(!this.buffers)
 this.buffers=[chunk];
 else
-this.buffers.push(chunk);
+ArrayPrototypePush(this.buffers,chunk);
 this.nread+=chunk.length;
 if(this.nread>this._maxOutputLength){
 this.close();
@@ -268,7 +273,7 @@ function ZlibBase(opts, mode, handle,{flush, finishFlush, fullFlush }){
 }
 }
 
-Transform.call(this,{autoDestroy: true, ...opts});
+ReflectApply(Transform,this,[{autoDestroy: true, ...opts}]);
 this[kError]=null;
 this.bytesWritten=0;
 this._handle=handle;
@@ -458,7 +463,7 @@ function processChunkSync(self, chunk, flushFlag){
 if(!buffers)
 buffers=[out];
 else
-buffers.push(out);
+ArrayPrototypePush(buffers,out);
 nread+=out.byteLength;
 
 if(nread>self._maxOutputLength){
@@ -671,7 +676,7 @@ function Zlib(opts, mode){
 processCallback,
 dictionary);
 
-ZlibBase.call(this,opts,mode,handle,zlibDefaultOpts);
+ReflectApply(ZlibBase,this,[opts,mode,handle,zlibDefaultOpts]);
 
 this._level=level;
 this._strategy=strategy;
@@ -699,7 +704,8 @@ Zlib.prototype.params = function params(level, strategy, callback){
 
 if(this._level!==level||this._strategy!==strategy){
 this.flush(Z_SYNC_FLUSH,
-paramsAfterFlushCallback.bind(this,level,strategy,callback));
+FunctionPrototypeBind(paramsAfterFlushCallback,this,
+level,strategy,callback));
 }else{
 process.nextTick(callback);
 }
@@ -710,31 +716,31 @@ Zlib.prototype.params = function params(level, strategy, callback){
 functionDeflate(opts){
 if(!(thisinstanceofDeflate))
 returnnewDeflate(opts);
-Zlib.call(this,opts,DEFLATE);
+ReflectApply(Zlib,this,[opts,DEFLATE]);
 }
 ObjectSetPrototypeOf(Deflate.prototype,Zlib.prototype);
 ObjectSetPrototypeOf(Deflate,Zlib);
 
 functionInflate(opts){
 if(!(thisinstanceofInflate))
 returnnewInflate(opts);
-Zlib.call(this,opts,INFLATE);
+ReflectApply(Zlib,this,[opts,INFLATE]);
 }
 ObjectSetPrototypeOf(Inflate.prototype,Zlib.prototype);
 ObjectSetPrototypeOf(Inflate,Zlib);
 
 functionGzip(opts){
 if(!(thisinstanceofGzip))
 returnnewGzip(opts);
-Zlib.call(this,opts,GZIP);
+ReflectApply(Zlib,this,[opts,GZIP]);
 }
 ObjectSetPrototypeOf(Gzip.prototype,Zlib.prototype);
 ObjectSetPrototypeOf(Gzip,Zlib);
 
 functionGunzip(opts){
 if(!(thisinstanceofGunzip))
 returnnewGunzip(opts);
-Zlib.call(this,opts,GUNZIP);
+ReflectApply(Zlib,this,[opts,GUNZIP]);
 }
 ObjectSetPrototypeOf(Gunzip.prototype,Zlib.prototype);
 ObjectSetPrototypeOf(Gunzip,Zlib);
@@ -743,23 +749,23 @@ function DeflateRaw(opts){
 if(opts&&opts.windowBits===8)opts.windowBits=9;
 if(!(thisinstanceofDeflateRaw))
 returnnewDeflateRaw(opts);
-Zlib.call(this,opts,DEFLATERAW);
+ReflectApply(Zlib,this,[opts,DEFLATERAW]);
 }
 ObjectSetPrototypeOf(DeflateRaw.prototype,Zlib.prototype);
 ObjectSetPrototypeOf(DeflateRaw,Zlib);
 
 functionInflateRaw(opts){
 if(!(thisinstanceofInflateRaw))
 returnnewInflateRaw(opts);
-Zlib.call(this,opts,INFLATERAW);
+ReflectApply(Zlib,this,[opts,INFLATERAW]);
 }
 ObjectSetPrototypeOf(InflateRaw.prototype,Zlib.prototype);
 ObjectSetPrototypeOf(InflateRaw,Zlib);
 
 functionUnzip(opts){
 if(!(thisinstanceofUnzip))
 returnnewUnzip(opts);
-Zlib.call(this,opts,UNZIP);
+ReflectApply(Zlib,this,[opts,UNZIP]);
 }
 ObjectSetPrototypeOf(Unzip.prototype,Zlib.prototype);
 ObjectSetPrototypeOf(Unzip,Zlib);
@@ -779,9 +785,10 @@ function createConvenienceMethod(ctor, sync){
 };
 }
 
-constkMaxBrotliParam=MathMax(...ObjectKeys(constants).map((key)=>{
-returnkey.startsWith('BROTLI_PARAM_') ? constants[key] : 0;
-}));
+constkMaxBrotliParam=MathMax(...ArrayPrototypeMap(
+ObjectKeys(constants),
+(key)=>(key.startsWith('BROTLI_PARAM_') ? constants[key] : 0)
+));
 
 constbrotliInitParamsArray=newUint32Array(kMaxBrotliParam+1);
 
@@ -793,7 +800,7 @@ const brotliDefaultOpts ={
 functionBrotli(opts,mode){
 assert(mode===BROTLI_DECODE||mode===BROTLI_ENCODE);
 
-brotliInitParamsArray.fill(-1);
+TypedArrayPrototypeFill(brotliInitParamsArray,-1);
 if(opts&&opts.params){
 for(constorigKeyofObjectKeys(opts.params)){
 constkey=+origKey;
@@ -824,23 +831,23 @@ function Brotli(opts, mode){
 thrownewERR_ZLIB_INITIALIZATION_FAILED();
 }
 
-ZlibBase.call(this,opts,mode,handle,brotliDefaultOpts);
+ReflectApply(ZlibBase,this,[opts,mode,handle,brotliDefaultOpts]);
 }
 ObjectSetPrototypeOf(Brotli.prototype,Zlib.prototype);
 ObjectSetPrototypeOf(Brotli,Zlib);
 
 functionBrotliCompress(opts){
 if(!(thisinstanceofBrotliCompress))
 returnnewBrotliCompress(opts);
-Brotli.call(this,opts,BROTLI_ENCODE);
+ReflectApply(Brotli,this,[opts,BROTLI_ENCODE]);
 }
 ObjectSetPrototypeOf(BrotliCompress.prototype,Brotli.prototype);
 ObjectSetPrototypeOf(BrotliCompress,Brotli);
 
 functionBrotliDecompress(opts){
 if(!(thisinstanceofBrotliDecompress))
 returnnewBrotliDecompress(opts);
-Brotli.call(this,opts,BROTLI_DECODE);
+ReflectApply(Brotli,this,[opts,BROTLI_DECODE]);
 }
 ObjectSetPrototypeOf(BrotliDecompress.prototype,Brotli.prototype);
 ObjectSetPrototypeOf(BrotliDecompress,Brotli);