zlib: refactor to use more primordials

[aduh95]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[aduh95]

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/745/console (queued, will 404 until it starts)

[benjamingr]

I have no idea how with all those extra arrays call vs. apply and the extra step - brotili is 10% faster

[aduh95]

Benchmark results:

 confidence improvement accuracy (*) (**) (***) zlib/creation.js n=500000 options='false' type='BrotliCompress' ** 5.76 % ±3.82% ±5.09% ±6.62% zlib/creation.js n=500000 options='false' type='BrotliDecompress' *** 9.91 % ±5.29% ±7.06% ±9.23% zlib/creation.js n=500000 options='false' type='InflateRaw' ** 5.32 % ±3.34% ±4.45% ±5.81% zlib/creation.js n=500000 options='true' type='BrotliCompress' * 5.75 % ±4.66% ±6.20% ±8.07% zlib/creation.js n=500000 options='true' type='BrotliDecompress' *** 8.71 % ±4.39% ±5.85% ±7.62% zlib/creation.js n=500000 options='true' type='InflateRaw' * 3.95 % ±3.60% ±4.80% ±6.25% 

Details

 confidence improvement accuracy (*) (**) (***) zlib/createInflate.js n=100 chunkLen=1024 inputLen=16777216 4.53 % ±5.83% ±7.75% ±10.10% zlib/creation.js n=500000 options='false' type='BrotliCompress' ** 5.76 % ±3.82% ±5.09% ±6.62% zlib/creation.js n=500000 options='false' type='BrotliDecompress' *** 9.91 % ±5.29% ±7.06% ±9.23% zlib/creation.js n=500000 options='false' type='Deflate' -1.14 % ±3.16% ±4.21% ±5.49% zlib/creation.js n=500000 options='false' type='DeflateRaw' 2.50 % ±4.08% ±5.42% ±7.06% zlib/creation.js n=500000 options='false' type='Gunzip' 1.94 % ±3.99% ±5.32% ±6.93% zlib/creation.js n=500000 options='false' type='Gzip' 1.27 % ±3.61% ±4.80% ±6.26% zlib/creation.js n=500000 options='false' type='Inflate' 2.72 % ±3.32% ±4.42% ±5.75% zlib/creation.js n=500000 options='false' type='InflateRaw' ** 5.32 % ±3.34% ±4.45% ±5.81% zlib/creation.js n=500000 options='false' type='Unzip' 3.37 % ±4.67% ±6.23% ±8.14% zlib/creation.js n=500000 options='true' type='BrotliCompress' * 5.75 % ±4.66% ±6.20% ±8.07% zlib/creation.js n=500000 options='true' type='BrotliDecompress' *** 8.71 % ±4.39% ±5.85% ±7.62% zlib/creation.js n=500000 options='true' type='Deflate' -0.91 % ±3.18% ±4.24% ±5.51% zlib/creation.js n=500000 options='true' type='DeflateRaw' -0.44 % ±4.47% ±5.95% ±7.76% zlib/creation.js n=500000 options='true' type='Gunzip' 1.68 % ±4.16% ±5.54% ±7.21% zlib/creation.js n=500000 options='true' type='Gzip' -2.62 % ±4.54% ±6.05% ±7.89% zlib/creation.js n=500000 options='true' type='Inflate' 2.80 % ±4.67% ±6.21% ±8.08% zlib/creation.js n=500000 options='true' type='InflateRaw' * 3.95 % ±3.60% ±4.80% ±6.25% zlib/creation.js n=500000 options='true' type='Unzip' 1.36 % ±4.76% ±6.34% ±8.25% zlib/deflate.js n=400000 inputLen=1024 method='createDeflate' -0.79 % ±11.18% ±14.88% ±19.38% zlib/deflate.js n=400000 inputLen=1024 method='deflate' 0.83 % ±5.10% ±6.78% ±8.82% zlib/deflate.js n=400000 inputLen=1024 method='deflateSync' 3.35 % ±10.48% ±13.94% ±18.15% zlib/inflate.js n=400000 inputLen=1024 method='inflate' -2.39 % ±3.16% ±4.21% ±5.48% zlib/inflate.js n=400000 inputLen=1024 method='inflateSync' -0.32 % ±4.20% ±5.59% ±7.27% zlib/pipe.js algorithm='brotli' type='buffer' duration=5 inputLen=1024 -0.38 % ±2.83% ±3.77% ±4.92% zlib/pipe.js algorithm='brotli' type='string' duration=5 inputLen=1024 -0.33 % ±1.14% ±1.52% ±1.98% zlib/pipe.js algorithm='gzip' type='buffer' duration=5 inputLen=1024 -0.98 % ±5.79% ±7.70% ±10.04% zlib/pipe.js algorithm='gzip' type='string' duration=5 inputLen=1024 -1.84 % ±3.67% ±4.89% ±6.37% Be aware that when doing many comparisons the risk of a false-positive result increases. In this case there are 28 comparisons, you can thus expect the following amount of false-positive results: 1.40 false positives, when considering a 5% risk acceptance (*, **, ***), 0.28 false positives, when considering a 1% risk acceptance (**, ***), 0.03 false positives, when considering a 0.1% risk acceptance (***) 

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/34701/

[Trott]

Landed in e4d570f