Skip to content

Commit 7e23080

Browse files
addaleaxtargos
authored andcommitted
test: pass through stderr in benchmark tests
This helps a lot with debugging failing benchmark tests, which would otherwise just print an assertion for the exit code (something like `+1 -0`, which yields almost no information about a failure). PR-URL: #21860 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
1 parent 52020dc commit 7e23080

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

‎test/common/benchmark.js‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,10 @@ function runBenchmark(name, args, env){
2020

2121
constmergedEnv=Object.assign({},process.env,env);
2222

23-
constchild=fork(runjs,argv,{env: mergedEnv,stdio: 'pipe'});
23+
constchild=fork(runjs,argv,{
24+
env: mergedEnv,
25+
stdio: ['inherit','pipe','inherit','ipc']
26+
});
2427
child.stdout.setEncoding('utf8');
2528

2629
letstdout='';

0 commit comments

Comments
(0)