test: pass through stderr in benchmark tests#21860
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This helps a lot with debugging failing benchmark tests, which would otherwise just print an assertion for the exit code (something like `+1 -0`, which yields almost no information about a failure).
gireeshpunathil commented Jul 18, 2018
@addaleax - why is the third entry (in the stdio array) required? |
addaleax commented Jul 18, 2018
@gireeshpunathil I’m not sure I understand – the first one is for stdin, which we don’t really care about, the second one is for stdout (which is what we’re testing here, so we need to capture it). The third one is for stderr; that’s the debugging information that should not get lost in the parent process. The fourth one is necessary for |
gireeshpunathil commented Jul 18, 2018
my apologies - I meant the 4th entry (somehow the 0 based index concept messed up with the natural language).
Can you please elaborate? missing to catch this. Is it for |
addaleax commented Jul 18, 2018
@gireeshpunathil I think I think we might be able to switch to another |
addaleax commented Jul 18, 2018
addaleax added the author ready 
addaleax commented Jul 26, 2018
Trott commented Jul 28, 2018
Trott commented Jul 28, 2018
Just fixed AIX in CI (I hope): https://ci.nodejs.org/job/node-test-pull-request/16049/ |
trivikr commented Aug 1, 2018
Landed in 8a62cdb |
This helps a lot with debugging failing benchmark tests, which would otherwise just print an assertion for the exit code (something like `+1 -0`, which yields almost no information about a failure). PR-URL: #21860 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
This helps a lot with debugging failing benchmark tests, which would otherwise just print an assertion for the exit code (something like `+1 -0`, which yields almost no information about a failure). PR-URL: #21860 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
8 participants
This helps a lot with debugging failing benchmark tests,
which would otherwise just print an assertion for the
exit code (something like
+1 -0, which yields almost noinformation about a failure).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes