test: more regression tests for minDHSize option

Check that tls.connect() fails in the expected way when passing in invalid minDHSize options. PR-URL: #3629 Reviewed-By: Sakthipriyan Vairamani <[email protected]>

Author: bnoordhuis

lib/_tls_wrap.js

@@ -974,7 +974,7 @@ exports.connect = function(/* [port, host], options, cb */){
 assert(typeofoptions.minDHSize==='number',
 'options.minDHSize is not a number: '+options.minDHSize);
 assert(options.minDHSize>0,
-'options.minDHSize is not a posivie number: '+
+'options.minDHSize is not a positive number: '+
 options.minDHSize);
 
 varhostname=options.servername||

test/parallel/test-tls-client-mindhsize.js

@@ -78,6 +78,15 @@ testDHE1024();
 assert.throws(()=>test(512,true,assert.fail),
 /DHparameterislessthan1024bits/);
 
+[0,-1,-Infinity,NaN].forEach(minDHSize=>{
+assert.throws(()=>tls.connect({ minDHSize }),
+/minDHSizeisnotapositivenumber/);
+});
+
+[true,false,null,undefined,{},[],'','1'].forEach(minDHSize=>{
+assert.throws(()=>tls.connect({ minDHSize }),/minDHSizeisnotanumber/);
+});
+
 process.on('exit',function(){
 assert.equal(nsuccess,1);
 assert.equal(nerror,1);