test: more regression tests for minDHSize option#3629
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bnoordhuis added crypto 
Contributor
There was a problem hiding this comment.
Since we are doing this, can we include Infinity and NaN?
MemberAuthor
There was a problem hiding this comment.
I added tests for negative infinity and nan. I left out positive infinity because I'm not even sure what it would mean to want keys of infinite size.
Contributor
There was a problem hiding this comment.
I left out positive infinity because I'm not even sure what it would mean to want keys of infinite size.
Infinite quantum entropy?
bnoordhuisforce-pushed the more-mindhsize-tests branch from 8f66027 to 752e19bCompareMemberAuthor
bnoordhuis commented Nov 2, 2015
Contributor
thefourtheye commented Nov 3, 2015
LGTM |
Check that trying to use a < 1024 bits DH key throws an exception. parallel/test-tls-dhe tests this as well but it feels incongruous not to do it here when both tests have similar logic for 1024/2048 bits keys. PR-URL: nodejs#3629 Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Check that tls.connect() fails in the expected way when passing in invalid minDHSize options. PR-URL: nodejs#3629 Reviewed-By: Sakthipriyan Vairamani <[email protected]>
bnoordhuisforce-pushed the more-mindhsize-tests branch from 752e19b to 82022a7Compare
bnoordhuis added a commit that referenced this pull request Nov 7, 2015
Check that trying to use a < 1024 bits DH key throws an exception. parallel/test-tls-dhe tests this as well but it feels incongruous not to do it here when both tests have similar logic for 1024/2048 bits keys. PR-URL: #3629 Reviewed-By: Sakthipriyan Vairamani <[email protected]>
bnoordhuis added a commit that referenced this pull request Nov 7, 2015
Check that tls.connect() fails in the expected way when passing in invalid minDHSize options. PR-URL: #3629 Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Merged
Contributor
MylesBorins commented Nov 16, 2015
Closed
Member
jasnell commented Feb 17, 2016
@nodejs/lts ... please weigh in on this one... this LGTM for v4.4 |
Contributor
MylesBorins commented Feb 17, 2016
it is worth noting that this relies on a semver major change from #1831 |
Member
rvagg commented Feb 18, 2016
yeah, this is not for v4.x cause |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI: https://ci.nodejs.org/job/node-test-pull-request/658/