lib: move function declaration outside of loop

sanjaiyan-dev · RafaelGSS · commit 8f845eb00152 · 2024-01-02T15:05:25.000-03:00
PR-URL: #51242 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
diff --git a/lib/internal/per_context/primordials.js b/lib/internal/per_context/primordials.js
@@ -541,11 +541,14 @@ primordials.SafePromiseAllReturnVoid = (promises, mapFn) =>
 new Promise((resolve, reject) =>{
 let pendingPromises = promises.length;
 if (pendingPromises === 0) resolve();
+ const onFulfilled = () =>{
+ if (--pendingPromises === 0){
+ resolve();
+ }
+ };
 for (let i = 0; i < promises.length; i++){
 const promise = mapFn != null ? mapFn(promises[i], i) : promises[i];
- PromisePrototypeThen(PromiseResolve(promise), () =>{
- if (--pendingPromises === 0) resolve();
- }, reject);
+ PromisePrototypeThen(PromiseResolve(promise), onFulfilled, reject);
 }
 });
 

-Original file line number
+Diff line change
 newPromise((resolve,reject)=>{
 letpendingPromises=promises.length;
 if(pendingPromises===0)resolve();
 +constonFulfilled=()=>{
 +if(--pendingPromises===0){
 +resolve();
 +}
 +};
 for(leti=0;i<promises.length;i++){
 constpromise=mapFn!=null ? mapFn(promises[i],i) : promises[i];
 -PromisePrototypeThen(PromiseResolve(promise),()=>{
 -if(--pendingPromises===0)resolve();
 -},reject);
 +PromisePrototypeThen(PromiseResolve(promise),onFulfilled,reject);
+}
 });