Optimize Memory Usage by Hoisting Function in For Loop 💽#51242
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
aduh95 approved these changes Dec 20, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Fix variable naming Co-authored-by: Antoine du Hamel <[email protected]>
Fix variable naming Co-authored-by: Antoine du Hamel <[email protected]>
aduh95 approved these changes Dec 20, 2023
anonrig approved these changes Dec 21, 2023
aduh95 added author ready 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Dec 21, 2023
aymen94 approved these changes Dec 21, 2023
Contributor
aduh95 commented Dec 23, 2023
Landed in b8fe07d |
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
PR-URL: #51242 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51242 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this pull request introduces a very minor improvement in memory usage by hoisting the function outside the for loop. This adjustment offers benefits such as reducing the overhead of redefining the function in each iteration, resulting in a more optimized and efficient code execution.
Extremely sorry, if I made any mistakes :)