test: harden test-gc-http-client-timeout

* decrease number of requests 500 -> 300 * extract 'cb' to a file-local function This should make test more reliable and less resource intensive. PR-URL: #23184 Refs: #23066 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: lundibundi

test/sequential/test-gc-http-client-timeout.js

@@ -3,7 +3,7 @@
 // just like test-gc-http-client.js,
 // but with a timeout set
 
-require('../common');
+constcommon=require('../common');
 constonGC=require('../common/ongc');
 
 functionserverHandler(req,res){
@@ -15,46 +15,44 @@ function serverHandler(req, res){
 }
 
 consthttp=require('http');
-consttodo=550;
+consttodo=300;
 letdone=0;
 letcount=0;
 letcountGC=0;
 
 console.log(`We should do ${todo} requests`);
 
 constserver=http.createServer(serverHandler);
-server.listen(0,getall);
+server.listen(0,common.mustCall(getall));
 
 functiongetall(){
 if(count>=todo)
 return;
 
-(function(){
-functioncb(res){
-res.resume();
-done+=1;
-}
+constreq=http.get({
+hostname: 'localhost',
+pathname: '/',
+port: server.address().port
+},cb);
 
-constreq=http.get({
-hostname: 'localhost',
-pathname: '/',
-port: server.address().port
-},cb);
+req.setTimeout(10,function(){
+console.log('timeout (expected)');
+});
 
-req.setTimeout(10,function(){
-console.log('timeout (expected)');
-});
-
-count++;
-onGC(req,{ ongc });
-})();
+count++;
+onGC(req,{ ongc });
 
 setImmediate(getall);
 }
 
 for(leti=0;i<10;i++)
 getall();
 
+functioncb(res){
+res.resume();
+done+=1;
+}
+
 functionongc(){
 countGC++;
 }