test: improve test-gc-http-client-timeout#23184
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* decrease number of requests 500 -> 300 * extract 'cb' to a file-local function This should make test more reliable and less resource intensive.
lundibundi changed the title 
thefourtheye approved these changes Sep 30, 2018
MemberAuthor
lundibundi commented Sep 30, 2018
BridgeAR approved these changes Oct 1, 2018
lundibundi added the author ready MemberAuthor
@addaleax@BridgeAR@thefourtheye what do you think of this suggestion
I mentioned in the first post? Edit: resume CI: https://ci.nodejs.org/job/node-test-pull-request/17552/ |
jasnell approved these changes Oct 1, 2018
Contributor
danbev commented Oct 4, 2018
Landed in 69a422b. |
danbev pushed a commit that referenced this pull request Oct 4, 2018
* decrease number of requests 500 -> 300 * extract 'cb' to a file-local function This should make test more reliable and less resource intensive. PR-URL: #23184 Refs: #23066 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Contributor
thefourtheye commented Oct 4, 2018
@lundibundi That suggestion can be done separately. Get a PR up, let's see what people think. |
targos pushed a commit that referenced this pull request Oct 5, 2018
* decrease number of requests 500 -> 300 * extract 'cb' to a file-local function This should make test more reliable and less resource intensive. PR-URL: #23184 Refs: #23066 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Oct 10, 2018
jasnell pushed a commit that referenced this pull request Oct 17, 2018
* decrease number of requests 500 -> 300 * extract 'cb' to a file-local function This should make test more reliable and less resource intensive. PR-URL: #23184 Refs: #23066 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make test more reliable and less resource intensive.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAlso, by moving for-loop of getall calls into the server callback I managed to run this with '-j 32 --repeat 1920' on a 4 core, 8 thread machine. Though this removes 'surefire' timeouts (due to a server being unavailable) this test will still get the timeouts due to the sheer amount of requests being made. Therefore if it's okay I'll make the change.
Refs: #23066
(not fixes as this still fails in parallel on '-j 32 --repeat 1920' locally)