tools: enable no-unsafe-finally

This enables the `no-unsafe-finally` eslint rule to make sure we have a proper control flow in try / catch. Backport-PR-URL: #19244 PR-URL: #18745 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: BridgeAR

.eslintrc.yaml

@@ -157,6 +157,7 @@ rules:
 }]
 no-tabs: error
 no-trailing-spaces: error
+no-unsafe-finally: error
 object-curly-spacing: [error, always]
 one-var-declaration-per-line: error
 operator-linebreak: [error, after]

lib/timers.js

@@ -314,24 +314,24 @@ function tryOnTimeout(timer, list){
 }
 }
 
-if(!threw)return;
-
-// Postpone all later list events to next tick. We need to do this
-// so that the events are called in the order they were created.
-constlists=list._unrefed===true ? unrefedLists : refedLists;
-for(varkeyinlists){
-if(key>list.msecs){
-lists[key].nextTick=true;
+if(threw){
+// Postpone all later list events to next tick. We need to do this
+// so that the events are called in the order they were created.
+constlists=list._unrefed===true ? unrefedLists : refedLists;
+for(varkeyinlists){
+if(key>list.msecs){
+lists[key].nextTick=true;
+}
 }
+// We need to continue processing after domain error handling
+// is complete, but not by using whatever domain was left over
+// when the timeout threw its exception.
+constdomain=process.domain;
+process.domain=null;
+// If we threw, we need to process the rest of the list in nextTick.
+process.nextTick(listOnTimeoutNT,list);
+process.domain=domain;
 }
-// We need to continue processing after domain error handling
-// is complete, but not by using whatever domain was left over
-// when the timeout threw its exception.
-constdomain=process.domain;
-process.domain=null;
-// If we threw, we need to process the rest of the list in nextTick.
-process.nextTick(listOnTimeoutNT,list);
-process.domain=domain;
 }
 }
 

test/common/index.js

@@ -514,21 +514,13 @@ exports.canCreateSymLink = function(){
 constwhoamiPath=path.join(process.env.SystemRoot,
 'System32','whoami.exe');
 
-leterr=false;
-letoutput='';
-
 try{
-output=execSync(`${whoamiPath} /priv`,{timout: 1000});
+constoutput=execSync(`${whoamiPath} /priv`,{timout: 1000});
+returnoutput.includes('SeCreateSymbolicLinkPrivilege');
 }catch(e){
-err=true;
-}finally{
-if(err||!output.includes('SeCreateSymbolicLinkPrivilege')){
-returnfalse;
-}
+returnfalse;
 }
 }
-
-returntrue;
 };
 
 exports.getCallSite=functiongetCallSite(top){