tools: enable no-unsafe-finally#18745
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This enables the `no-unsafe-finally` eslint rule to make sure we have a proper control flow in try / catch.
bnoordhuis approved these changes Feb 13, 2018
test/common/index.js Outdated
| constoutput=execSync(`${whoamiPath} /priv`,{timout: 1000}); | ||
| if(!output.includes('SeCreateSymbolicLinkPrivilege')){ | ||
| returnfalse; | ||
| } |
Member
There was a problem hiding this comment.
Can be simplified to just this, I think?
returnoutput.includes('SeCreateSymbolicLinkPrivilege');And then you don't need the return true a few lines below.
MemberAuthor
BridgeAR commented Feb 13, 2018
BridgeAR added the author ready 
cjihrig approved these changes Feb 13, 2018
lpinca approved these changes Feb 13, 2018
jasnell approved these changes Feb 13, 2018
mmarchini approved these changes Feb 15, 2018
MemberAuthor
BridgeAR commented Feb 16, 2018
Landed in 4d3c3f0 |
BridgeAR added a commit to BridgeAR/node that referenced this pull request Feb 16, 2018
This enables the `no-unsafe-finally` eslint rule to make sure we have a proper control flow in try / catch. PR-URL: nodejs#18745 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Contributor
MylesBorins commented Feb 21, 2018
There is another unsafe finally in v9.x, would you be willing to manually backport and fix it so we can review? |
4 tasks
MemberAuthor
BridgeAR commented Mar 10, 2018
Backported in #19244 that removed the other unsafe finally as well. |
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 21, 2018
This enables the `no-unsafe-finally` eslint rule to make sure we have a proper control flow in try / catch. PR-URL: nodejs#18745 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
This enables the `no-unsafe-finally` eslint rule to make sure we have a proper control flow in try / catch. Backport-PR-URL: #19244 PR-URL: #18745 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
This enables the `no-unsafe-finally` eslint rule to make sure we have a proper control flow in try / catch. PR-URL: nodejs#18745 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Contributor
MylesBorins commented Jul 31, 2018
Backport requested for 8.x in #19244 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the
no-unsafe-finallyeslint rule to make sure wehave a proper control flow in try / catch.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools