trace_events: respect inspect() depth

cjihrig · BridgeAR · commit 9dd840dff58a · 2019-06-17T19:49:51.000+02:00
This commit causes the Tracing class to account for util.inspect() depth. PR-URL: #28037 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
diff --git a/lib/trace_events.js b/lib/trace_events.js
@@ -61,6 +61,9 @@ class Tracing{
 }
 
 [customInspectSymbol](depth, opts){
+ if (typeof depth === 'number' && depth < 0)
+ return this;
+
 const obj ={
 enabled: this.enabled,
 categories: this.categories
diff --git a/test/parallel/test-util-inspect.js b/test/parallel/test-util-inspect.js
@@ -2497,3 +2497,15 @@ assert.strictEqual(
 assert(i < 2 || line.startsWith('\u001b[90m'));
 });
 }
+
+{
+ // Tracing class respects inspect depth.
+ try{
+ const trace = require('trace_events').createTracing({categories: ['fo'] });
+ const actual = util.inspect({trace },{depth: 0 });
+ assert.strictEqual(actual, '{trace: [Tracing] }');
+ } catch (err){
+ if (err.code !== 'ERR_TRACE_EVENTS_UNAVAILABLE')
+ throw err;
+ }
+}

Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,9 @@ class Tracing{`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`[customInspectSymbol](depth,opts){`
	`64`	`+if(typeofdepth==='number'&&depth<0)`
	`65`	`+returnthis;`
	`66`	`+`
`64`	`67`	`constobj={`
`65`	`68`	`enabled: this.enabled,`
`66`	`69`	`categories: this.categories`
-Original file line number
+Diff line change
 assert(i<2||line.startsWith('\u001b[90m'));
 });
+}
++
 +{
 +// Tracing class respects inspect depth.
 +try{
 +consttrace=require('trace_events').createTracing({categories: ['fo']});
 +constactual=util.inspect({ trace },{depth: 0});
 +assert.strictEqual(actual,'{trace: [Tracing] }');
 +}catch(err){
 +if(err.code!=='ERR_TRACE_EVENTS_UNAVAILABLE')
 +throwerr;
 +}
 +}