trace_events: respect inspect() depth#28037
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
addaleax approved these changes Jun 3, 2019
Collaborator
nodejs-github-bot commented Jun 3, 2019
Collaborator
nodejs-github-bot commented Jun 3, 2019
Collaborator
nodejs-github-bot commented Jun 3, 2019
Collaborator
nodejs-github-bot commented Jun 3, 2019
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/23597/ EDIT(cjihrig): CI was yellow. |
lpinca approved these changes Jun 3, 2019
BridgeAR approved these changes Jun 4, 2019
BridgeAR added author ready 
This commit causes the Tracing class to account for util.inspect() depth. PR-URL: nodejs#28037 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
This commit causes the Tracing class to account for util.inspect() depth. PR-URL: #28037 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit causes the
Tracingclass to account forutil.inspect()depth.Similar to #27983. After this commit, all of these cases in core are handled.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes