test: resolve path of embedtest binary correctly

zcbenz · richardlau · commit a1feae24cb68 · 2024-03-25T17:27:52.000Z
PR-URL: #50276 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
diff --git a/test/embedding/test-embedding.js b/test/embedding/test-embedding.js
@@ -14,12 +14,11 @@ tmpdir.refresh();
 common.allowGlobals(global.require);
 common.allowGlobals(global.embedVars);
 
-function resolveBuiltBinary(bin){
- let binary = `out/${common.buildType}/${bin}`;
+function resolveBuiltBinary(binary){
 if (common.isWindows){
 binary += '.exe';
 }
- return path.resolve(__dirname, '..', '..', binary);
+ return path.join(path.dirname(process.execPath), binary);
 }
 
 const binary = resolveBuiltBinary('embedtest');

Original file line number	Diff line number	Diff line change
`@@ -14,12 +14,11 @@ tmpdir.refresh();`
`14`	`14`	`common.allowGlobals(global.require);`
`15`	`15`	`common.allowGlobals(global.embedVars);`
`16`	`16`
`17`		`-functionresolveBuiltBinary(bin){`
`18`		-letbinary=`out/${common.buildType}/${bin}`;
	`17`	`+functionresolveBuiltBinary(binary){`
`19`	`18`	`if(common.isWindows){`
`20`	`19`	`binary+='.exe';`
`21`	`20`	`}`
`22`		`-returnpath.resolve(__dirname,'..','..',binary);`
	`21`	`+returnpath.join(path.dirname(process.execPath),binary);`
`23`	`22`	`}`
`24`	`23`
`25`	`24`	`constbinary=resolveBuiltBinary('embedtest');`