test: correctly resolve path of embedtest binary#50276
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Oct 19, 2023
20 tasks
lpinca approved these changes Oct 20, 2023
Collaborator
nodejs-github-bot commented Oct 20, 2023
This was referenced Oct 21, 2023
jasnell approved these changes Oct 28, 2023
ContributorAuthor
zcbenz commented Nov 13, 2023
Can this be merged? It is required for running tests with the GN build of Node. |
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Nov 13, 2023
25 tasks
27 tasks
26 tasks
ContributorAuthor
zcbenz commented Nov 27, 2023
Ping for merging after the holiday. |
Collaborator
nodejs-github-bot commented Nov 28, 2023
anonrig approved these changes Nov 28, 2023
anonrig added the author ready 
aduh95 added request-ci Collaborator
nodejs-github-bot commented Nov 29, 2023
Contributor
aduh95 commented Dec 5, 2023
Landed in 4957994 |
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
PR-URL: #50276 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #50276 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
embedtestbinary is usually generated under the same directory with thenodebinary.The
outdirectory is not necessarily in the source code directory, so current way will fail when Node.js is built as a component of other projects.