console: minor timeLogImpl() refactor

This commit does two things: - Reverses the boolean value returned by timeLogImpl(). The new values make more sense semantically (IMO anyway), and save a a single NOT operation. - Explicitly check for undefined when calling _times.get() instead of coercing the value. PR-URL: #29100 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Author: cjihrig

lib/internal/console/constructor.js

@@ -310,9 +310,9 @@ const consoleMethods ={
 timeEnd(label='default'){
 // Coerces everything other than Symbol to a string
 label=`${label}`;
-consthasWarned=timeLogImpl(this,'timeEnd',label);
+constfound=timeLogImpl(this,'timeEnd',label);
 trace(kTraceEnd,kTraceConsoleCategory,`time::${label}`,0);
-if(!hasWarned){
+if(found){
 this._times.delete(label);
 }
 },
@@ -509,12 +509,12 @@ const consoleMethods ={
 },
 };
 
-// Returns true if label was not found
+// Returns true if label was found
 functiontimeLogImpl(self,name,label,data){
 consttime=self._times.get(label);
-if(!time){
+if(time===undefined){
 process.emitWarning(`No such label '${label}' for console.${name}()`);
-returntrue;
+returnfalse;
 }
 constduration=process.hrtime(time);
 constms=duration[0]*1000+duration[1]/1e6;
@@ -523,7 +523,7 @@ function timeLogImpl(self, name, label, data){
 }else{
 self.log('%s: %sms',label,ms.toFixed(3), ...data);
 }
-returnfalse;
+returntrue;
 }
 
 constkeyKey='Key';