console: minor timeLogImpl() refactor#29100
Closed
+6 −6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This commit does two things: - Reverses the boolean value returned by timeLogImpl(). The new values make more sense semantically (IMO anyway), and save a a single NOT operation. - Explicitly check for undefined when calling _times.get() instead of coercing the value.
nodejs-github-bot added the console 
jasnell approved these changes Aug 13, 2019
antsmartian approved these changes Aug 13, 2019
Trott approved these changes Aug 13, 2019
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
patilharshal16 left a comment
patilharshal16 left a comment There was a problem hiding this comment.
Not sure about changed return type otherwise looks good
targos approved these changes Aug 13, 2019
lpinca approved these changes Aug 13, 2019
Collaborator
nodejs-github-bot commented Aug 13, 2019
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/24968/ EDIT: CI passed |
Trott added the author ready 
patilharshal16 approved these changes Aug 14, 2019
Member
ZYSzys commented Aug 15, 2019
Landed in a15cd9d. |
ZYSzys pushed a commit that referenced this pull request Aug 15, 2019
This commit does two things: - Reverses the boolean value returned by timeLogImpl(). The new values make more sense semantically (IMO anyway), and save a a single NOT operation. - Explicitly check for undefined when calling _times.get() instead of coercing the value. PR-URL: #29100 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Aug 19, 2019
This commit does two things: - Reverses the boolean value returned by timeLogImpl(). The new values make more sense semantically (IMO anyway), and save a a single NOT operation. - Explicitly check for undefined when calling _times.get() instead of coercing the value. PR-URL: #29100 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Aug 20, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit does two things:
timeLogImpl(). The new values make more sense semantically (IMO anyway), and save a a single NOT operation.undefinedwhen calling_times.get()instead of coercing the value.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes