repl: support hidden history file on Windows

On Windows when REPL history file has the hidden attribute node will fail when trying to open it in 'w' mode. This changes the mode to 'r+'. The file is guaranteed to exists because of earlier open call with 'a+'. Fixes: #5261 PR-URL: #12207 Reviewed-By: James M Snell <[email protected]>

Author: bzoz

lib/internal/repl.js

@@ -165,10 +165,19 @@ function setupHistory(repl, historyPath, oldHistoryPath, ready){
 }
 }
 
-fs.open(historyPath,'w',onhandle);
+fs.open(historyPath,'r+',onhandle);
 }
 
 functiononhandle(err,hnd){
+if(err){
+returnready(err);
+}
+fs.ftruncate(hnd,0,(err)=>{
+returnonftruncate(err,hnd);
+});
+}
+
+functiononftruncate(err,hnd){
 if(err){
 returnready(err);
 }

test/fixtures/.empty-hidden-repl-history-file

@@ -76,6 +76,8 @@ const oldHistoryPath = path.join(fixtures, 'old-repl-history-file.json');
 constenoentHistoryPath=path.join(fixtures,'enoent-repl-history-file.json');
 constemptyHistoryPath=path.join(fixtures,'.empty-repl-history-file');
 constdefaultHistoryPath=path.join(common.tmpDir,'.node_repl_history');
+constemptyHiddenHistoryPath=path.join(fixtures,
+'.empty-hidden-repl-history-file');
 
 consttests=[
 {
@@ -163,6 +165,19 @@ const tests = [
 test: [UP],
 expected: [prompt,replFailedRead,prompt,replDisabled,prompt]
 },
+{
+before: functionbefore(){
+if(common.isWindows){
+constexecSync=require('child_process').execSync;
+execSync(`ATTRIB +H "${emptyHiddenHistoryPath}"`,(err)=>{
+assert.ifError(err);
+});
+}
+},
+env: {NODE_REPL_HISTORY: emptyHiddenHistoryPath},
+test: [UP],
+expected: [prompt]
+},
 {// Make sure this is always the last test, since we change os.homedir()
 before: functionbefore(){
 // Mock os.homedir() failure