repl: support hidden history file on Windows#12207
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
On Windows when REPL history file has the hidden attribute node will fail when trying to open it in 'w' mode. This changes the mode to 'r+'. The file is guaranteed to exists because of earlier open call with 'a+'.
Fishrock123 previously requested changes Apr 4, 2017
| } | ||
| fs.open(historyPath,'w',onhandle); | ||
| fs.open(historyPath,'r+',onhandle); |
Contributor
There was a problem hiding this comment.
Won't this break creating a new file if none exists? [1]
Contributor
Fishrock123 commented Apr 4, 2017
| if(err){ | ||
| returnready(err); | ||
| } | ||
| fs.ftruncate(hnd,0,(err)=>{ |
Contributor
There was a problem hiding this comment.
From what I am gathering, the mode change no longer cause overwrites (appends instead) and so we need to "flush" the file?
From the docs though, it sounds like it does writes and not appends, so this shouldn't be necessary?
'r+' - Open file for reading and writing. An exception occurs if the file does not exist.
ContributorAuthor
There was a problem hiding this comment.
Previous implementation cleared the file once when opening it with w. This was the only place that would reset history file content - i.e. if one would set NODE_REPL_HISTORY_SIZE to value lower than 1000, then the history file would be trimmed when node starts. This ftruncate call here is to preserve this functionality.
ghost commented Apr 5, 2017
That's a good idea |
ghost approved these changes Apr 16, 2017
ContributorAuthor
bzoz commented Apr 20, 2017
Windows test fail unrelated. Landed in bb041ea |
bzoz added a commit that referenced this pull request Apr 20, 2017
On Windows when REPL history file has the hidden attribute node will fail when trying to open it in 'w' mode. This changes the mode to 'r+'. The file is guaranteed to exists because of earlier open call with 'a+'. Fixes: #5261 PR-URL: #12207 Reviewed-By: James M Snell <[email protected]>
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
On Windows when REPL history file has the hidden attribute node will fail when trying to open it in 'w' mode. This changes the mode to 'r+'. The file is guaranteed to exists because of earlier open call with 'a+'. Fixes: #5261 PR-URL: #12207 Reviewed-By: James M Snell <[email protected]>
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
On Windows when REPL history file has the hidden attribute node will fail when trying to open it in 'w' mode. This changes the mode to 'r+'. The file is guaranteed to exists because of earlier open call with 'a+'. Fixes: #5261 PR-URL: #12207 Reviewed-By: James M Snell <[email protected]>
evanlucas pushed a commit that referenced this pull request May 2, 2017
On Windows when REPL history file has the hidden attribute node will fail when trying to open it in 'w' mode. This changes the mode to 'r+'. The file is guaranteed to exists because of earlier open call with 'a+'. Fixes: #5261 PR-URL: #12207 Reviewed-By: James M Snell <[email protected]>
Member
gibfahn commented May 16, 2017
Should this be backported to v6.x? |
3 tasks
Contributor
mscdex commented May 26, 2017
Wherever this gets backported, we also need #12762. |
3 tasks
Member
gibfahn commented Jun 18, 2017
Landed this with #12762, LMK if that wasn't a good idea. |
gibfahn pushed a commit that referenced this pull request Jun 18, 2017
On Windows when REPL history file has the hidden attribute node will fail when trying to open it in 'w' mode. This changes the mode to 'r+'. The file is guaranteed to exists because of earlier open call with 'a+'. Fixes: #5261 PR-URL: #12207 Reviewed-By: James M Snell <[email protected]>
ContributorAuthor
bzoz commented Jun 19, 2017
LGTM |
gibfahn pushed a commit that referenced this pull request Jun 20, 2017
On Windows when REPL history file has the hidden attribute node will fail when trying to open it in 'w' mode. This changes the mode to 'r+'. The file is guaranteed to exists because of earlier open call with 'a+'. Fixes: #5261 PR-URL: #12207 Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
On Windows when REPL history file has the hidden attribute node will fail when trying to open it in 'w' mode. This changes the mode to 'r+'. The file is guaranteed to exists because of earlier open call with 'a+'. Fixes: #5261 PR-URL: #12207 Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows when REPL history file has the hidden attribute node will fail when trying to open it in
wmode. This changes the mode tor+. The file is guaranteed to exists because of earlier open call witha+.Fixes: #5261
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
repl